From: Markus Elfring <Markus.Elfring@web.de>
To: "Paul Cercueil" <paul@crapouillou.net>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, dmaengine@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
"Christian König" <christian.koenig@amd.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure
Date: Mon, 17 Jun 2024 08:56:50 +0200 [thread overview]
Message-ID: <6a41fd88-5496-462a-86d2-446c2990fcf7@web.de> (raw)
In-Reply-To: <20240605110845.86740-4-paul@crapouillou.net>
…
> +++ b/drivers/iio/industrialio-buffer.c
…
> static int iio_buffer_chrdev_release(struct inode *inode, struct file *filep)
> {
…
> wake_up(&buffer->pollq);
>
> + mutex_lock(&buffer->dmabufs_mutex);
> +
> + /* Close all attached DMABUFs */
…
> + mutex_unlock(&buffer->dmabufs_mutex);
> +
> kfree(ib);
…
Would you become interested to apply a statement like “guard(mutex)(&buffer->dmabufs_mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-17 6:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 11:08 [PATCH v10 0/6] iio: new DMABUF based API v10 Paul Cercueil
2024-06-05 11:08 ` [PATCH v10 1/6] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec() Paul Cercueil
2024-06-11 16:29 ` Vinod Koul
2024-06-05 11:08 ` [PATCH v10 2/6] dmaengine: dma-axi-dmac: Implement device_prep_peripheral_dma_vec Paul Cercueil
2024-06-05 11:08 ` [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure Paul Cercueil
2024-06-09 9:53 ` Jonathan Cameron
2024-06-15 11:07 ` Paul Cercueil
2024-06-17 6:24 ` Nuno Sá
2024-06-17 6:56 ` Markus Elfring [this message]
2024-06-18 9:25 ` Paul Cercueil
2024-06-05 11:08 ` [PATCH v10 4/6] iio: buffer-dma: Enable support for DMABUFs Paul Cercueil
2024-06-09 9:55 ` Jonathan Cameron
2024-06-05 11:08 ` [PATCH v10 5/6] iio: buffer-dmaengine: Support new DMABUF based userspace API Paul Cercueil
2024-06-05 11:08 ` [PATCH v10 6/6] Documentation: iio: Document high-speed DMABUF based API Paul Cercueil
2024-06-06 17:32 ` Randy Dunlap
2024-06-07 7:44 ` Paul Cercueil
2024-06-08 23:44 ` Randy Dunlap
2024-06-09 9:58 ` [PATCH v10 0/6] iio: new DMABUF based API v10 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a41fd88-5496-462a-86d2-446c2990fcf7@web.de \
--to=markus.elfring@web.de \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paul@crapouillou.net \
--cc=rdunlap@infradead.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox