From: Md Shofiqul Islam <shofiqtest@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v6 0/3] iio: health: add MAX86150 ECG and PPG biosensor driver
Date: Mon, 06 Jul 2026 15:38:36 -0700 (PDT) [thread overview]
Message-ID: <6a4c2e6c.e49deeb0.d08a9.bbaa@mx.google.com> (raw)
In-Reply-To: <20260706185041.0e31ec94@jic23-huawei>
Jonathan,
You are right, and I apologize. I sent v6 before working through your
driver review, which wasted your time and the time of the other
reviewers. That was a mistake on my part.
v7 is ready and addresses all feedback from your July 2 driver review:
the driver has been rewritten to use the kfifo buffer pattern (like
MAX30100/MAX30102), the IIO_TRIGGER dependency has been removed,
register field macros have been renamed with the correct convention,
IIO_DMA_MINALIGN and IIO_DECLARE_BUFFER_WITH_TS are used,
regmap_noinc_read length is corrected, and the remaining style points
(fsleep, NSEC_PER_MSEC, regmap_set/clear_bits, goto cleanup) are all
addressed. The DT binding changes from your v5 review were already in v6.
I will send v7 shortly.
Md Shofiqul Islam
next prev parent reply other threads:[~2026-07-06 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260623140730.12574-1-shofiqtest@gmail.com>
2026-07-06 11:22 ` [PATCH v6 0/3] iio: health: add MAX86150 ECG and PPG biosensor driver Md Shofiqul Islam
2026-07-06 11:22 ` [PATCH v6 1/3] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
2026-07-07 6:23 ` Krzysztof Kozlowski
2026-07-06 11:22 ` [PATCH v6 2/3] iio: health: add MAX86150 ECG and PPG biosensor driver Md Shofiqul Islam
2026-07-06 17:48 ` Jonathan Cameron
2026-07-06 11:22 ` [PATCH v6 3/3] MAINTAINERS: add entry for MAX86150 IIO health driver Md Shofiqul Islam
2026-07-06 17:41 ` Jonathan Cameron
2026-07-06 17:50 ` [PATCH v6 0/3] iio: health: add MAX86150 ECG and PPG biosensor driver Jonathan Cameron
2026-07-06 22:38 ` Md Shofiqul Islam [this message]
2026-07-07 2:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4c2e6c.e49deeb0.d08a9.bbaa@mx.google.com \
--to=shofiqtest@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox