From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54B51E493C for ; Tue, 7 Jan 2025 23:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293259; cv=none; b=GVUFyOVvU/2khKRy4XJyXbxjp0GCyOIT10VoLwnmqxjlK/PvNmImkt9oa0oeslShHu3DePVuL7gbB5rW5HvSpbUAbNg51EX5pt/YQi6M5TLFva91p4Gu1NhC3E00YZ6iW7l8ufO0X29tBkVo8D5taR6BHWFKGcyrti0gc3CiZAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293259; c=relaxed/simple; bh=vY3TG3+Uru+KujoSXwhGQJx4QFHJrYIK51bTcCgFbTM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hRcDWiSky++ptvJYGdaH+yLANUw0hGbSzesQgs9H2tOfmhL+ciWdxxRADLXqDmiBHgbioe3Q6Nt3J28wZby5/LMLOHoTQtucKvY8kiLnJdbL+lrgA1UCs3W+2XGbxaAk/e9D8vx0MBDk/+Dkg+GeOj5pnPEso+XvP8wwUuRF9dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=XGnfxwNC; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="XGnfxwNC" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3eba583fbe8so5413435b6e.3 for ; Tue, 07 Jan 2025 15:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736293257; x=1736898057; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hA9SMIRGl/zMWWHv+Ri/ux3lkoHtjeTWyaOGSnC9Hc8=; b=XGnfxwNCc0CrjZzcUqTbXm1smku4Km/qIsNcAbEgJaF/FbhWWbq+HV1H0MNW374NEL S0vAopqA5fXwTA9/ZHvYvZDOsr3l9rnaIwaJgEEkiAqWTHP+8TzyRSwHs4OASbFrnswc 2c6n11qwWLYC1ufmvPeO5C8ZDPnjSXtV9WBpPktIcCY4tdq357hSNTppnSX9ZYqcW6Eu EGyMIcUwyIkK6PGPmjoq+kfOJZB3ABDA64FGXrXT4IIR6IvfibfLOAdW7bK2VAm8RgS5 uChiCkR/lUxbRaHIaYs2IQ52broldzH/NPKSNFPWBvKVwtZsrrOSAFOpCS2q4AeS33e9 LbKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736293257; x=1736898057; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hA9SMIRGl/zMWWHv+Ri/ux3lkoHtjeTWyaOGSnC9Hc8=; b=lFRWvQBmdoojUYHe8lxKbqOuILUvVK8IZqZ5Cr7BwZC8YhqDhbkKNFZQb9CknBRmbl Joy0d/ss6mWc5OpzTLak7u0lQZkOd5YL0eWdijCh5YM0DsfnxOq7vRUtwveigCEX9XYH 5kmv3rWEN3DdrA0Pzo5jOThYi01W926aXdWLF+mqKduoZf/bF5iXywaJjA62dq5zMTeD sLA7x7/WQ2vwgdeslR+CNVsZSUESpP4+VwtrQVOXfTw2f5iIRsP/T/UD3hb0OW81ERg7 2IjQIiuFmaOV+NdXBhlxGJddmwIGHSzfEUubZ8Obipw89nkiKXmgFKo17WHHfuXmVQpc secQ== X-Forwarded-Encrypted: i=1; AJvYcCU8x1lTNLEPbgi1MfOz6f3CxBlZBzC3X6VAfb5Wr2+K04lmAUTfZxDJJDt6bt+jIXQsY0/44E0kcSs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxaf5EF0hbBI1S7IPFiOxb6zVtlkdgttPVlj6cta8PDoqOadDrX O0kIbWb1DO4BiYy5WrwH/+3H8nq3oM2e28Vg/gatsOmawSbAE14fWoyfvlVB0Pg= X-Gm-Gg: ASbGncvK7CWwELfytJuGyG+EqJEORklbCsWo3Y5U6r2U4gduyekrtfANZvzwZ2U2y4z HgjKrtSiPTtneKEkS9oiIALlS3ZfP6VdDe64K4Eet5v1qZ2Xjj8fq7kmjFw0/FrWLLyN60+Eu4p sM9Z4cIZtlm0prJ6cLKKj+OoqyiWUdqs3QVq+a8SeQjqQg0S87S4CzsCr6XUQdnKnrUVX1z29pv KPq3MpXgz0agZZpLRSeZMSeEVY158c8KWfPmbHn3CQqyK6La0tUNJRPWXUWyiJHI4Hd3TQ+BOCD uLCqJ87FK5MPe3dGKA== X-Google-Smtp-Source: AGHT+IEgB/WWksiX3jt4m5035Fhdbgpeqq/NdpXf+C0NbgMNenjn6UZUe5f6Mk4QAPVqauJHK/ySZg== X-Received: by 2002:a05:6808:220e:b0:3e7:bd97:759a with SMTP id 5614622812f47-3ef2eeb0d61mr379709b6e.39.1736293256882; Tue, 07 Jan 2025 15:40:56 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ece247e117sm10792562b6e.14.2025.01.07.15.40.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 15:40:55 -0800 (PST) Message-ID: <6b60de31-4bbb-4a94-a62b-63ccbacdf1b4@baylibre.com> Date: Tue, 7 Jan 2025 17:40:53 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/15] iio: adc: ad7768-1: Add reset gpio To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sergiu Cuciurean , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com References: <45cfd15501384a183a97d871b6848fb79fdb7b39.1736201898.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <45cfd15501384a183a97d871b6848fb79fdb7b39.1736201898.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 9:25 AM, Jonathan Santos wrote: > From: Sergiu Cuciurean > > Depending on the controller, the default state of a gpio can vary. This > change excludes the probability that the dafult state of the ADC reset > gpio will be HIGH if it will be passed as reference in the deivcetree. > > Signed-off-by: Sergiu Cuciurean > --- > drivers/iio/adc/ad7768-1.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index 881446462ff5..f73b9aec8b0f 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -161,6 +161,7 @@ struct ad7768_state { > struct completion completion; > struct iio_trigger *trig; > struct gpio_desc *gpio_sync_in; > + struct gpio_desc *gpio_reset; > const char *labels[ARRAY_SIZE(ad7768_channels)]; > /* > * DMA (thus cache coherency maintenance) may require the > @@ -441,6 +442,18 @@ static int ad7768_setup(struct ad7768_state *st) > { > int ret; > > + st->gpio_reset = devm_gpiod_get_optional(&st->spi->dev, "reset", > + GPIOD_OUT_LOW); Could be simplified by setting this to GPIOD_OUT_HIGH and drop gpiod_direction_output(st->gpio_reset, 1); > + if (IS_ERR(st->gpio_reset)) > + return PTR_ERR(st->gpio_reset); > + > + if (st->gpio_reset) { > + gpiod_direction_output(st->gpio_reset, 1); > + usleep_range(10, 15); > + gpiod_direction_output(st->gpio_reset, 0); > + usleep_range(10, 15); prefer fsleep() > + } > + We can move the code below in an else since we don't need to do 2 resets. > /* > * Two writes to the SPI_RESET[1:0] bits are required to initiate > * a software reset. The bits must first be set to 11, and then