From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D45F38F63E for ; Mon, 16 Mar 2026 10:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658253; cv=none; b=neREZk9bYb4pct9wrNvLazr5SR8RNsBI0E7hKp4phHLyOBzUC1zj+UN8cV0q/2ra0OMmd1cUvK4LbbQlO4KLxR8aGCWeffh4afa1cOBgol8HFUM8GZKEwKoWQjv394TlyewKT/OGKhKbW96i5Q6OS/zeB0XE/XtyZTHJ97FSLd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658253; c=relaxed/simple; bh=WuphdEG5WMxLm6CNAhSgSsU6b0QIPWdhcGxytQxDhYg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MMRsU7pXdP0c92rW2VAKcJd2gUDpug331djI2So+T4ADuleWHBjK5051yi3GdpszHtHKcrFRa9gWZbSLI9bLvMBKxUb2yCBUxeuVDwOYuSVwNd4WUKGpgSjllZPdLX969HU8FGWkAf4t5bd2VBJE/3B5BVkLuzpNEaBT/jN7OwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M6KzD6Pw; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M6KzD6Pw" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b9431300833so664618366b.0 for ; Mon, 16 Mar 2026 03:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773658251; x=1774263051; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zX8fXT4dHsVZo0l5cubooJwv9HgtnAM6ONAUv7CG/fA=; b=M6KzD6PwcDBQIurPbir85r8pKHXKRKvTDPGiys1DP+DpQdsRT6jxbKM5lN5Uo1d0mC qEfWaP5s2QyE74wXIWEbmxVI+eC7y0SDlPNqhP8eZ+fXcvpFrOzJtEVao0MyjsTXMpzf Hhtehg10NKPFwzClLdoS8Vh+ifarA0vS8ijxz5Rs/VtiFmGKtQP0YWifeiX1MnajLoIt VE2qrswvd3SGB/bld90gl9GNBxN5CNs2G0FWkHmUWh/vHiqc18OXYzlVnQLVGLIgsrZf nLjscrbhwt248WYCrqfQ9TRtz/X6BcsVZYJTMBCxPZ0HcN++1n4vF1ZJrUbw17aHwMtt dwGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773658251; x=1774263051; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zX8fXT4dHsVZo0l5cubooJwv9HgtnAM6ONAUv7CG/fA=; b=UKMCqaWDfA4qAX0SfS3rZK8MmGG2GWeBYKww0KRRIhLAYoZexeqXehz5Pds05ZJXs7 YSUArxBDzS+xD4P6GwTvWIRBj7SGL9sXRw+VbNSVoczO8GlaWiN5FVrlZyhOET7Jmtf5 0tBQVlKDF1LahKIOg5oEjkzeB5/09jC/uvx2mGvNcuvbXJ3+y6B3dt2wz29WgY9SwQCy 6pLTtQpOWEXcsG1pjXD3geb2kECRDAIle0x85Jq6ikppHXa6SyG5EUBOHGXX10rRqlDm 35sr/monf6T2PQ2Eh2bQMn7C3ue2MWWaPdb7i5xyNM1XaSoojhBPOkmvlq0ywVRO87P8 NkIA== X-Forwarded-Encrypted: i=1; AJvYcCWdYc9IT0IwxB60fxysbjoMBhheoa605V1idJGckCIukWVb6sec+tUUA3YXkmtIn4xrkFrlkCWyvIg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw88xQVdFl4zwarAdeR9Ph0su/Mh4QLqKuNo3Zzd7zRcT5LqFH4 3vSTGHTzs1i4K2yx38Ae9Vf9xZ/aw32IS7jwlEbwqpMK2LUFUsQ4rjf8 X-Gm-Gg: ATEYQzwHtPZfGFNRJXwxG9OxyDba3j/AWGMBiO8m9rFXmupPfpZ9IQ7BoLHCYLlvZp7 GBIyVqKiuLOcDcHV0BI8fK7ko9BE++YBbCOueDsLMTIMaJ/C6eL6QIs+dhKEyP4lRsZRqd4pkuS WVXNteszfFYMGIIh4aqRGDQ+JIZ86rDy0aPc7cINZqcsjRIZvFUP79o+yfRLnMiSAHB8MK1dxaq gp2y0vYFXodsL5sBhnocKLAg6kwexvSgk0eMO3DefA48hM9lvUxzdu7FqbzPi4W0V8pJc/Q9b8a //tJ9eWEVMfGpaykvPRGFRzrOE+ExvokrUioC3sLyIQjoO9aOxmrjwzgYCnJcm+hIoy2KGdDRH4 pAfQNHXQwpk7iYrfi4vG9E4NJkcxBMvHISEKDN3PnX7cYZgVzudPTN/AbRJ+cI0IxmVWwmopaC9 s5/MoE36p+tmhv+lP0OPklcaGt3A== X-Received: by 2002:a17:906:3554:b0:b97:1009:7536 with SMTP id a640c23a62f3a-b9765052b4fmr564364966b.15.1773658250384; Mon, 16 Mar 2026 03:50:50 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb49a5sm539384566b.31.2026.03.16.03.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:50:50 -0700 (PDT) Message-ID: <6cc8f5ab-2671-4975-b24c-b17d4aab656d@gmail.com> Date: Mon, 16 Mar 2026 12:50:48 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> <20260314-vcnl4000-regulators-v3-6-3c4a48d30676@gmail.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/16/26 12:39 PM, Andy Shevchenko wrote: > On Sat, Mar 14, 2026 at 06:06:35PM +0200, Erikas Bitovtas wrote: >> After moving data->client and client->dev into variables of their own, >> replace all instances of data->client and client->dev being used in >> vcnl4200_init and vcnl4000_probe by the said variables to reduce >> clutter. > > ... > >> - ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, >> + ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, >> regval); > > Now it's perfectly a single line. > > ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); > >> if (ret < 0) >> return ret; > > ... > >> regval = ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; >> - ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, >> + ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, >> regval); > > Ditto. > >> if (ret < 0) >> return ret; > >> - if (device_property_read_u32(&client->dev, "proximity-near-level", >> + if (device_property_read_u32(dev, "proximity-near-level", >> &data->near_level)) >> data->near_level = 0; > > The 'if' is redundant, I think you can drop it at some point, probably to avoid > churn in the follow up > > - if (device_property_read_u32(&client->dev, "proximity-near-level", > - data->near_level = 0; > + device_property_read_u32(dev, "proximity-near-level", &data->near_level); > device_property_read_u32() throws an error if a property is missing. Would data->near_level be left without an assigned default value in that case?