From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Marius Cristea <marius.cristea@microchip.com>,
Trevor Gamblin <tgamblin@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Subject: Re: [PATCH v1 00/13] iio: Clean up acpi_match_device() use cases
Date: Wed, 23 Oct 2024 17:36:19 +0200 [thread overview]
Message-ID: <6d6d038a-bc0a-4a13-9dcb-94e289767b44@redhat.com> (raw)
In-Reply-To: <20241023152145.3564943-1-andriy.shevchenko@linux.intel.com>
Hi,
On 23-Oct-24 5:17 PM, Andy Shevchenko wrote:
> There are current uses of acpi_match_device():
> - as strange way of checking if the device was enumerated via ACPI
> - as a way to get IIO device name as ACPI device instance name
> - as above with accompanying driver data
>
> Deduplicate its use by providing two new helper functions in IIO ACPI
> library and update the rest accordingly.
>
> This also includes a rework of previously sent ltr501 patch.
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
for the series.
Regards,
Hans
> Andy Shevchenko (13):
> iio: magnetometer: bmc150: Drop dead code from the driver
> iio: adc: pac1934: Replace strange way of checking type of enumeration
> iio: imu: inv_mpu6050: Replace strange way of checking type of
> enumeration
> iio: acpi: Improve iio_read_acpi_mount_matrix()
> iio: acpi: Add iio_get_acpi_device_name_and_data() helper function
> iio: accel: mma9551: Replace custom implementation of
> iio_get_acpi_device_name()
> iio: accel: mma9553: Replace custom implementation of
> iio_get_acpi_device_name()
> iio: gyro: bmg160: Replace custom implementation of
> iio_get_acpi_device_name()
> iio: light: isl29018: Replace a variant of
> iio_get_acpi_device_name_and_data()
> iio: light: isl29018: drop ACPI_PTR() and CONFIG_ACPI guards
> iio: light: ltr501: Drop most likely fake ACPI IDs
> iio: light: ltr501: Add LTER0303 to the supported devices
> iio: light: ltr501: Replace a variant of
> iio_get_acpi_device_name_and_data()
>
> drivers/iio/accel/mma9551.c | 19 ++-------
> drivers/iio/accel/mma9553.c | 19 ++-------
> drivers/iio/adc/pac1934.c | 2 +-
> drivers/iio/gyro/bmg160_core.c | 15 --------
> drivers/iio/gyro/bmg160_i2c.c | 4 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 5 +--
> drivers/iio/industrialio-acpi.c | 45 ++++++++++++++++++++--
> drivers/iio/light/isl29018.c | 38 ++++++------------
> drivers/iio/light/ltr501.c | 29 +++++---------
> drivers/iio/magnetometer/bmc150_magn.c | 15 --------
> include/linux/iio/iio.h | 10 +++++
> 11 files changed, 86 insertions(+), 115 deletions(-)
>
next prev parent reply other threads:[~2024-10-23 15:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 15:17 [PATCH v1 00/13] iio: Clean up acpi_match_device() use cases Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 01/13] iio: magnetometer: bmc150: Drop dead code from the driver Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 02/13] iio: adc: pac1934: Replace strange way of checking type of enumeration Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 03/13] iio: imu: inv_mpu6050: " Andy Shevchenko
2024-10-24 12:24 ` Jean-Baptiste Maneyrol
2024-10-23 15:17 ` [PATCH v1 04/13] iio: acpi: Improve iio_read_acpi_mount_matrix() Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 05/13] iio: acpi: Add iio_get_acpi_device_name_and_data() helper function Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 06/13] iio: accel: mma9551: Replace custom implementation of iio_get_acpi_device_name() Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 07/13] iio: accel: mma9553: " Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 08/13] iio: gyro: bmg160: " Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 09/13] iio: light: isl29018: Replace a variant of iio_get_acpi_device_name_and_data() Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 10/13] iio: light: isl29018: drop ACPI_PTR() and CONFIG_ACPI guards Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 11/13] iio: light: ltr501: Drop most likely fake ACPI IDs Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 12/13] iio: light: ltr501: Add LTER0303 to the supported devices Andy Shevchenko
2024-10-23 15:17 ` [PATCH v1 13/13] iio: light: ltr501: Replace a variant of iio_get_acpi_device_name_and_data() Andy Shevchenko
2024-10-23 15:36 ` Hans de Goede [this message]
2024-10-24 7:52 ` [PATCH v1 00/13] iio: Clean up acpi_match_device() use cases Jonathan Cameron
2024-10-24 8:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d6d038a-bc0a-4a13-9dcb-94e289767b44@redhat.com \
--to=hdegoede@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox