From: "Dmitry Maslov" <maslovdmitry@seeed.cc>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
north_sea@qq.com, baozhu.zuo@seeed.cc, jian.xiong@seeed.cc
Subject: Re: Re: Re: [PATCH v3] iio: light: ltr501: Added ltr303 driver support
Date: Tue, 2 Nov 2021 03:55:35 +0800 (GMT+08:00) [thread overview]
Message-ID: <6f764cb4.e6.17cdd1249ee.Coremail.maslovdmitry@seeed.cc> (raw)
In-Reply-To: <CAHp75Vc+Yqcq=gtpMgzb5pDc9nuNbzzwVjfsTg20hZ7VfAQ88w@mail.gmail.com>
> -----Original Messages-----
> From: "Andy Shevchenko" <andy.shevchenko@gmail.com>
> Sent Time: 2021-11-01 16:20:35 (Monday)
> To: "Dmitry Maslov" <maslovdmitry@seeed.cc>
> Cc: "Jonathan Cameron" <jic23@kernel.org>, linux-iio <linux-iio@vger.kernel.org>, "Lars-Peter Clausen" <lars@metafoo.de>, north_sea@qq.com, baozhu.zuo@seeed.cc, jian.xiong@seeed.cc
> Subject: Re: Re: [PATCH v3] iio: light: ltr501: Added ltr303 driver support
>
> On Mon, Nov 1, 2021 at 3:57 PM Dmitry Maslov <maslovdmitry@seeed.cc> wrote:
> > > From: "Andy Shevchenko" <andy.shevchenko@gmail.com>
> > > Sent Time: 2021-10-31 22:07:09 (Sunday)
> > > On Sun, Oct 31, 2021 at 6:46 PM Maslov Dmitry <maslovdmitry@seeed.cc> wrote:
>
> ...
>
> > > > Signed-off-by: Maslov Dmitry <maslovdmitry@seeed.cc>
> > >
> > > I believe it should be Dmitry Maslov, i.e. First name Last name.
> >
> > I could change that, but I do not think there is an international standard for that. The reason I put Maslov Dmitry
> > is to be in line with corporate email address, which belongs to a Chinese company - in China surname is put first
> > on the legal documents.
>
> Hmm... You are right, there is no such requirement in the Submitting
> Patches document.
> ...
>
> > > > @@ -1597,6 +1610,7 @@ static const struct acpi_device_id ltr_acpi_match[] = {
> > > > {"LTER0501", ltr501},
> > > > {"LTER0559", ltr559},
> > > > {"LTER0301", ltr301},
> > > > + {"LTER0303", ltr303},
> > >
> > > Any evidence of this ACPI ID being in the wild, please?
> >
> > I'm sorry, I do not exactly understand the question. Do you mean where that particular sensor is used?
>
> Can you provide a name of the machine which has this ID in its DSDT
> table, please?
We're submitting this patch specifically for reTerminal.
Here is DTS file for the reTerminal, currently awaiting merge in Raspberry Pi Linux kernel
repository.
https://github.com/raspberrypi/linux/blob/6ef732875d705ff15cc4c25d4d0a0eee87dc2a58/arch/arm/boot/dts/overlays/seeed-reterminal-core-overlay.dts#L99
So, while at the moment ACPI part is not being used, later we might use this sensor for other, x86 based
boards, for example ODYSSEY - X86J4125800.
Is there a particular reason you think this part should be omitted for LTR303?
next prev parent reply other threads:[~2021-11-01 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 16:46 [PATCH v3] iio: light: ltr501: Added ltr303 driver support Maslov Dmitry
2021-10-31 20:07 ` Andy Shevchenko
2021-11-01 13:57 ` Dmitry Maslov
2021-11-01 14:20 ` Andy Shevchenko
2021-11-01 19:55 ` Dmitry Maslov [this message]
2021-11-03 18:21 ` Jonathan Cameron
2021-11-04 22:25 ` Dmitry Maslov
2021-11-05 17:06 ` Jonathan Cameron
2021-11-03 18:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f764cb4.e6.17cdd1249ee.Coremail.maslovdmitry@seeed.cc \
--to=maslovdmitry@seeed.cc \
--cc=andy.shevchenko@gmail.com \
--cc=baozhu.zuo@seeed.cc \
--cc=jian.xiong@seeed.cc \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=north_sea@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox