From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jianping.Shen@de.bosch.com, jic23@kernel.org, lars@metafoo.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dima.fedrau@gmail.com, marcelo.schmitt1@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Christian.Lorenz3@de.bosch.com,
Ulrike.Frauendorf@de.bosch.com, Kai.Dolde@de.bosch.com
Subject: Re: [PATCH v2 2/2] iio: imu: smi240: imu driver
Date: Tue, 13 Aug 2024 17:57:30 +0200 [thread overview]
Message-ID: <703979cd-c189-41c0-a61c-eb7e90e225e6@kernel.org> (raw)
In-Reply-To: <20240809111635.106588-3-Jianping.Shen@de.bosch.com>
On 09/08/2024 13:16, Jianping.Shen@de.bosch.com wrote:
> +
> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@de.bosch.com>");
> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@de.bosch.com>");
> +MODULE_DESCRIPTION("Bosch SMI240 driver");
> +MODULE_LICENSE("Dual BSD/GPL");
Let's be clear here: if you bothered to look at your module, you would
see that it is duplicated. I judged by code review and questioned it.
This should lead you to double and triple check. But instead of
double-checking, you engage in long discussion with reviewer. Sorry,
that's wasting my time. Your job is to check it, if you got comments on
this, not mine.
Please carefully read upstreaming guides/presentations and which
mistakes to avoid. Hint: wasting reviewer's time.
NAK.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-13 15:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 11:16 [PATCH v2 0/2] iio: imu: smi240: cover-letter Jianping.Shen
2024-08-09 11:16 ` [PATCH v2 1/2] dt-bindings: iio: imu: smi240: devicetree binding Jianping.Shen
2024-08-09 14:19 ` Conor Dooley
2024-08-09 11:16 ` [PATCH v2 2/2] iio: imu: smi240: imu driver Jianping.Shen
2024-08-09 12:07 ` Christophe JAILLET
2024-08-09 12:18 ` Shen Jianping (ME-SE/EAD2)
2024-08-10 12:45 ` Krzysztof Kozlowski
2024-08-12 10:13 ` Shen Jianping (ME-SE/EAD2)
2024-08-10 12:44 ` Krzysztof Kozlowski
2024-08-13 9:41 ` Shen Jianping (ME-SE/EAD2)
2024-08-13 9:46 ` Krzysztof Kozlowski
2024-08-13 13:54 ` Shen Jianping (ME-SE/EAD2)
2024-08-13 14:37 ` Krzysztof Kozlowski
2024-08-13 14:51 ` Shen Jianping (ME-SE/EAD2)
2024-08-13 15:53 ` Krzysztof Kozlowski
2024-08-13 15:59 ` Krzysztof Kozlowski
2024-08-14 11:22 ` Shen Jianping (ME-SE/EAD2)
2024-08-13 15:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703979cd-c189-41c0-a61c-eb7e90e225e6@kernel.org \
--to=krzk@kernel.org \
--cc=Christian.Lorenz3@de.bosch.com \
--cc=Jianping.Shen@de.bosch.com \
--cc=Kai.Dolde@de.bosch.com \
--cc=Ulrike.Frauendorf@de.bosch.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox