From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: michael.srba@seznam.cz, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>
Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: imu: mpu6050: Document invensense,icm20608d
Date: Thu, 10 Mar 2022 17:34:25 +0100 [thread overview]
Message-ID: <707f995e-9b09-ea23-5fc7-74239792dcbd@canonical.com> (raw)
In-Reply-To: <20220310133938.2495-2-michael.srba@seznam.cz>
On 10/03/2022 14:39, michael.srba@seznam.cz wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
>
> ICM-20608-D differs from the other ICM-20608 variants by having
> a DMP (Digital Motion Processor) core tacked on.
> Despite having a different WHOAMI register, this variant is
> completely interchangeable with the other ICM-20608 variants
> by simply pretending the DMP core doesn't exist.
I wonder now why not using generic invensense,icm20608 compatible as
fallback? Why only having one specific compatible?
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> ---
> .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> index d69595a524c1..6784cc140323 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - invensense,iam20680
> - invensense,icm20608
> + - invensense,icm20608d
> - invensense,icm20609
> - invensense,icm20689
> - invensense,icm20602
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-10 16:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 13:39 [PATCH 0/2] iio: imu: inv_mpu6050: Add support for ICM-20608-D michael.srba
2022-03-10 13:39 ` [PATCH 1/2] dt-bindings: iio: imu: mpu6050: Document invensense,icm20608d michael.srba
2022-03-10 16:34 ` Krzysztof Kozlowski [this message]
2022-03-10 18:56 ` Michael Srba
2022-03-10 21:24 ` Krzysztof Kozlowski
2022-03-20 15:12 ` Jonathan Cameron
2022-03-21 8:04 ` Krzysztof Kozlowski
2022-03-21 15:04 ` Jonathan Cameron
2022-03-21 15:22 ` Krzysztof Kozlowski
2022-03-21 17:42 ` Jonathan Cameron
2022-03-21 18:07 ` Michael Srba
2022-03-22 10:19 ` Jonathan Cameron
2022-03-22 10:41 ` Krzysztof Kozlowski
2022-03-22 20:22 ` Jonathan Cameron
2022-03-22 10:23 ` Krzysztof Kozlowski
2022-03-22 20:29 ` Jonathan Cameron
2022-03-10 13:39 ` [PATCH 2/2] iio: imu: inv_mpu6050: Add support for ICM-20608-D michael.srba
2022-03-10 13:58 ` Jean-Baptiste Maneyrol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707f995e-9b09-ea23-5fc7-74239792dcbd@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael.srba@seznam.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox