From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] iio: chemical: ams-iaq-core: update driver name and DT match table To: Matt Ranostay References: <1470111916-9104-1-git-send-email-mranostay@gmail.com> <9e983e54-9de4-8fe8-477f-9dd0263b0f32@metafoo.de> Cc: "linux-iio@vger.kernel.org" , Jonathan Cameron From: Lars-Peter Clausen Message-ID: <73ab649b-e28f-6783-b4e7-aeb07c839859@metafoo.de> Date: Wed, 3 Aug 2016 22:08:51 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 08/03/2016 10:02 PM, Matt Ranostay wrote: > On Wed, Aug 3, 2016 at 5:13 AM, Lars-Peter Clausen wrote: >> On 08/02/2016 06:25 AM, Matt Ranostay wrote: >>> DT match name should be similar to the i2c device table entry. >> >> Why? > > To be consistent mostly. But I have noticed compatible = > "ams,iaq-core" doesn't actually match... Well, consistent with what? The normal pattern for devicetree compatible strings is vendor,partname. So that would suggest that ams,iaq-core is the preferred solution if it is supposed to be consistent. Btw. there seem to be no binding documents for this part. > Does anyone here know if i2c-core just checks the id_table, and not > of_match_table as well? > > Anyone have thoughts on this but I dig into this too deep? It uses of_match_table when it is set. See http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-core.c#n609