From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844791E5716 for ; Mon, 18 Nov 2024 19:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731959830; cv=none; b=CqkyPRxuxm/IFeYeK+JsUd4Ua9rr3L3UHA365Eo9o1qLTM7yL3JHzekKWL3eT1CMPumBWugYr+SAUlaBwmyPje9zV6paDtTm31bGnOXlH9K+pV02Y+kEQp6xBCZb3I9Tljj+4RBsHIAJyhcw+faheMqUXrAMlAWw4PyJNsYt6Sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731959830; c=relaxed/simple; bh=C3yvYvgaYqHUASV6J8b58Cin5xvUMyMbEuA9GZfTzY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WoGwLtkF3gUjUGIs84btQJMmKCpwpxbm6yfaJrgwubUwBOZWIzvXpSWjDW6FQTkz2PIs1iWKnMFT+n96znIgoCMcPoROE2oTgue5jxfKxm7ZvOAlXv3PK0/eBvDgTl2W3FIv/UxMBV3A+cEIxc9aNWnIalMqP88Ca8s0TpZ12vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HLW1cliL; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HLW1cliL" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5ee645cf763so2367277eaf.2 for ; Mon, 18 Nov 2024 11:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1731959826; x=1732564626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WpUyZvuIqoP+1REy1b0f27OiKQUxfmn+lI7QAkmm/bc=; b=HLW1cliLAleXC0tByReogt14ePO6yc2ynZoDWPcAkapgQPTy4xQI7Aw46W4zeM5x6g AF50e8jJiio8s1LYWBwITxOqBPtVwD0vQ5dR/8ffzwQqaFMGfO6EHnZJWUzkhhBPZfty pE+cpLrXImTHtekUBIaMjVAfSzWdx465TWCas1SZjwkJTzXHWf96JVI0BqErLF85bUhq i0pt8iSAzMTPwqjOj/psvl7H6CljblyaFbuUucqVJuhvYBA4olU7rJH//tQly57T3Sw8 y0mL7z/kesy0Krl8Nz+2ZRD/FYubh0HllnITXtqA7V4Ku9L+CYtPc4PiKeMBB4Zh64SE +Ixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731959826; x=1732564626; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WpUyZvuIqoP+1REy1b0f27OiKQUxfmn+lI7QAkmm/bc=; b=U70hAi9jzE7SnNPnWSioEW+l7M8P19G9ChCJjxM9iI8Riuz/bdM+ylazfvJhOv57JC X9EZdFYQRCR7yU6Lp0PfH9iLFYpyGVvOpRaV+e4tI2PLDmSVzq7wyAdJQipuFLqCccLt /oNEpCr3KSbrLHtZwikSiBKsAYa6M/C2irLMO2naxRxw8PzpDZRTopMYGRrrM0fTYwmP DVdYKmx9XOXjLh7CF0pEZf+lvI+KtBjHhL8RX/y4DtYzbROqoUZ1unM1C69YWou1RmRw vXRuDSOVUaqc8wDNjp+3Jq6f65TS7QbI6zkfWb6YnM0i5W2fUae/a/5Ow1fpIprDwY4p IDrA== X-Gm-Message-State: AOJu0Yy+0jZL8I00GV/ABVlJo0XF+jpB3R9U+wjMeD/fvqG/Rj/3aryu ibqTeknzZp8NG9EHeSzAOSybn07iwqyfjtxoqJVpQjGTGa6rVN7lhkzbc1Tl+0Y= X-Google-Smtp-Source: AGHT+IHQm8AvqbRlq+Us9nwiXv4QXlkWwfjqJbIZ5ekm5NvDdp7rFZJFhnT0J5xgIqNqiBjstaFupA== X-Received: by 2002:a05:6820:4c17:b0:5c4:144b:1ff9 with SMTP id 006d021491bc7-5eeab41f3ecmr10418542eaf.5.1731959826665; Mon, 18 Nov 2024 11:57:06 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5eeabd520c4sm3043554eaf.27.2024.11.18.11.57.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Nov 2024 11:57:05 -0800 (PST) Message-ID: <74ae05a9-6fff-4088-a46c-0a68a5b64614@baylibre.com> Date: Mon, 18 Nov 2024 13:57:03 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] iio: adc: ad4000: Use device specific timing for SPI transfers To: Marcelo Schmitt , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <284478615dd32deff29e4e10815cb49fa7d3b5d0.1731953012.git.marcelo.schmitt@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <284478615dd32deff29e4e10815cb49fa7d3b5d0.1731953012.git.marcelo.schmitt@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/18/24 12:53 PM, Marcelo Schmitt wrote: > The SPI transfers for AD4020, AD4021, and AD4022 have slightly different > timing specifications. Use device specific timing constraints to set SPI > transfer parameters. While tweaking time constraints, remove time related > defines including unused AD4000_TQUIET1_NS. > > Signed-off-by: Marcelo Schmitt > --- ... > +/* > + * Same timing specifications for all of AD4000, AD4001, ..., AD4008, AD4010, > + * ADAQ4001, and ADAQ4003. > + */ > +static const struct ad4000_time_spec ad4000_t_spec = AD4000_TSPEC(320, 60); > + > +/* AD4020, AD4021, AD4022 */ > +static const struct ad4000_time_spec ad4020_t_spec = AD4000_TSPEC(350, 60); I actually liked the way you did it in v1 better. This makes it harder to see which number is which.