Hi Jonathan, On Sun, 2026-08-16 at 03:59 +0100, Jonathan Cameron wrote: > On Thu, 13 Aug 2026 14:26:11 +0200 > Kanak Shilledar wrote: > > > Add support for the Invensense ICM42370P MEMS MotionTracking 3-axis > > accelerometer with a built-in temperature sensor. Compared to other > > sensors from the same vendor ICM42370 uses a different way of > > handling > > register banks. Although the device supports I2C, SPI, and I3C, > > implement only I2C support.  Provide basic support for raw sensor > > reads and a sysfs interface for setting the calibration bias. Keep > > the > > embedded temperature sensor enabled because the device design does > > not > > allow it to be turned off. > > > > Signed-off-by: Kanak Shilledar > Hi Kanak > > Welcome to IIO. Various comments below. Thanks for reviewing the code. As per the response from @Jean, I will drop this new file, and improve upon the existing Invensense, ICM42607 driver. While at it I will try to keep your comments in mind before sending out the v3. > > > diff --git a/drivers/iio/accel/inv_icm42370.h > > b/drivers/iio/accel/inv_icm42370.h > > new file mode 100644 > > index 0000000000000..a4a822f04355f > > --- /dev/null > > +++ b/drivers/iio/accel/inv_icm42370.h Best Regards, Kanak Shilledar