From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A11F13B58F; Sat, 9 Nov 2024 16:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731169100; cv=none; b=SHQzXdAPwD3BlAT49lcaxiA2wSX8pCLI5BUkRfWPpdPC7q6qo45p0bWg++rC7sWDkkRg9SVEz0G/mI0y1Ws1xHFpM8OCPPlkuQjTeroA1WHCKSKuV9zxFCH/LpB8e9XcfZKRhd2reF0e6o2oiIowdAy+CxbI7oSsjplOFnL+f24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731169100; c=relaxed/simple; bh=hTqUBfFBffJEBj1uzjpY2PAG3eELAsNWrn4sfuIw0NE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NwdTTv0fsA6f2CoBqSmaSbntgt/gjCoT0FrpWvIMlleMkJRYRhPbGGXD6XK9c4I+H934Dbd6jm81Vv0+zV3fhu+5c3NynIJtOKeJGrsq7QCOtqmJx7S3Q3nfjS8c+59h2h/PG81BX1aKhtUBcqVb/33kgZaw77YStfPzDL+bNqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cr7G1R/k; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cr7G1R/k" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71e61b47c6cso2861250b3a.2; Sat, 09 Nov 2024 08:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731169097; x=1731773897; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=AY0eebTXEIishDNyiwRb9ex+msXxW2kwSSAsfJd8Nb8=; b=cr7G1R/knYEsSqM094XLan4nRtpjLiU8VA9Mmz4BAxFeXlRDbZXOAf3u9YMRhUifru 07/3Rp6acu09q97dAsu5VybhAMNVYIfJxNzUxvqjTRVaO+/z3vEa8Y1e3rZ4BQ+HAKu8 wzWZGtawU5uMQWOBVdUfRuQQRUQX21O6FvgAq0n4K7drS/KnWJNIbYDZu/jt6j9cl4tZ 9PFuyA1y78reba85/qP870KpB4pQKIlDLn06Zb7FOSTvqFbTCl/HzFkxjiyeFikQMWDo crnxOcJDX4byMiejzlSFlV2kenV7APETDgkwWnV3nTGI9mf7VHtl3+h9tIzUeM2y5oRM JNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731169097; x=1731773897; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AY0eebTXEIishDNyiwRb9ex+msXxW2kwSSAsfJd8Nb8=; b=nvY7HxKB2kYqZm09kERvOu7KP3od4A2J7NuRmP14TsLYxPjSSogWipNb0OZ/lfU/UZ M3xUP8At63dnjL3H554uDgKeWCMmlngN/2YFXaFnTJGdbglSLRZSJ6Ah4TPGZg5UwHH3 qr9cqiCbjYeYIq9l7g9AkrMNZ9DTvgXZpelTxJdtkWqpwtcrCPs1wLUbaRfepev9nM9/ rRQ4k4skzmR96LiKrYlNp/LeyCFTtaoW5/NwmEfFjEFpfuNQYJoY9AJ540kd93q+JnAn 0KYEJ3beXe0Ver6lFOjJR/2uyp5iCR6qq8/pL+XkMwpnn+4MoAYqWSIRh8o7s10dYVGE o92Q== X-Forwarded-Encrypted: i=1; AJvYcCUnEvVmtqtaY/7CHs7r70wkRuCY4TgVYgiQLZ7ojqJLU5wtzO0yS58GLpnPWR4yv4eYEp18yd7KcAX3WRtf@vger.kernel.org, AJvYcCUxcuY5aRVEdLHhphTxSZ3eMksAQAFnlJm4KNKZOtyvvcxTUaJ7KJGd8CHKZz5m0RITie5LteDRv7nU9MM=@vger.kernel.org, AJvYcCX53nKnS2xi4g9veVGxVmF8EO5jkzeyEpOXGCdFkgR/Cd0Gkbj6akvunZKOljTGX4Mo17pmxKPLUaDK@vger.kernel.org, AJvYcCXbO1+d1o/R+guldj74bK1XwOPRftfHVGgDynlUvdY/Eg6U1YHpwTeN+gWxJD74q61s7gPwkxsyPhzW@vger.kernel.org X-Gm-Message-State: AOJu0YyuMysLZYI6u3oj2DXAzmr2c/ePA9s9FjJElAATk+SaTA19QL3g NrUkQc7Vc7dhtZyLrowsah7+f7f2NuFuupKyYq8Vu4ysSTfKSotI X-Google-Smtp-Source: AGHT+IFFEOTc0f7k5Cb6OmO3aw4cDMvRSI8MwQfTSwXzFv9H2IVb799+VMnovE4Cn08Pg7WFgIBy7Q== X-Received: by 2002:a17:903:41ca:b0:20c:82ea:41bd with SMTP id d9443c01a7336-21183c92bf3mr94499705ad.18.1731169096895; Sat, 09 Nov 2024 08:18:16 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e6b9besm48319275ad.248.2024.11.09.08.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Nov 2024 08:18:16 -0800 (PST) Sender: Guenter Roeck Message-ID: <76b6051e-fed5-4566-83da-9cbd198c237c@roeck-us.net> Date: Sat, 9 Nov 2024 08:18:13 -0800 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] hwmon: tmp108: Add support for I3C device To: Jonathan Cameron Cc: Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jean Delvare , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , linux-hwmon@vger.kernel.org References: <20241108-p3t1085-v2-0-6a8990a59efd@nxp.com> <20241108-p3t1085-v2-3-6a8990a59efd@nxp.com> <20241109131604.5d8b701a@jic23-huawei> <014410fc-8a4c-440f-a6eb-1fafccc444a6@roeck-us.net> <20241109151531.37ac4226@jic23-huawei> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20241109151531.37ac4226@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/9/24 07:15, Jonathan Cameron wrote: > On Sat, 9 Nov 2024 06:53:28 -0800 > Guenter Roeck wrote: > >> On 11/9/24 05:16, Jonathan Cameron wrote: >>> On Fri, 08 Nov 2024 17:26:57 -0500 >>> Frank Li wrote: >>> >>>> Add support for I3C device in the tmp108 driver to handle the P3T1085 >>>> sensor. Register the I3C device driver to enable I3C functionality for the >>>> sensor. >>>> >>>> Signed-off-by: Frank Li >>>> --- >>>> drivers/hwmon/tmp108.c | 31 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 31 insertions(+) >>>> >>>> diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c >>>> index bfbea6349a95f..83d6847cb542c 100644 >>>> --- a/drivers/hwmon/tmp108.c >>>> +++ b/drivers/hwmon/tmp108.c >>>> @@ -13,6 +13,8 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> +#include >>> >>> Seems odd you need master.h in a device driver. >>> I'll guess that's because you should be using i3cdev_to_device() >> >> I assume you mean i3cdev_to_dev() ? >> > Indeed! :( > >> Good point, but there are not many examples to draw from. The one >> existing iio driver (st_lsm6dsx) doesn't use it either. I'll send >> a patch shortly to fix that to prevent others from making the same >> mistake. > Excellent. In this context, are you by any chance aware of an USB<->I3C adapter wit decent price point ? With more I3C devices becoming available, I'd like to be able to test at least some of the code with real hardware. For I2C I use the Devantech USB-ISS adapter, but I have not yet found anything comparable for I3C, at least nothing that is affordable. Thanks, Guenter