From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] iio: core: make iio_bus_type const
Date: Fri, 09 Feb 2024 08:38:03 +0100 [thread overview]
Message-ID: <77e7ed84395c716e17d783e9411fd57ad8c22295.camel@gmail.com> (raw)
In-Reply-To: <20240208-bus_cleanup-iio-v1-1-4a167c3b5fb3@marliere.net>
On Thu, 2024-02-08 at 16:37 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the iio_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
Acked-by: Nuno Sa <nuno.sa@analog.com>
> drivers/iio/industrialio-core.c | 2 +-
> include/linux/iio/iio.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index e8551a1636ba..9b2877fe8689 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
> static dev_t iio_devt;
>
> #define IIO_DEV_MAX 256
> -struct bus_type iio_bus_type = {
> +const struct bus_type iio_bus_type = {
> .name = "iio",
> };
> EXPORT_SYMBOL(iio_bus_type);
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 4f89279e531c..e370a7bb3300 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
> int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
> void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
>
> -extern struct bus_type iio_bus_type;
> +extern const struct bus_type iio_bus_type;
>
> /**
> * iio_device_put() - reference counted deallocation of struct device
>
> ---
> base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
> change-id: 20240208-bus_cleanup-iio-1e5714e23bb9
>
> Best regards,
next prev parent reply other threads:[~2024-02-09 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 19:37 [PATCH] iio: core: make iio_bus_type const Ricardo B. Marliere
2024-02-09 7:38 ` Nuno Sá [this message]
2024-02-10 15:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77e7ed84395c716e17d783e9411fd57ad8c22295.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox