Re: [RESEND PATCH v5 3/5] IIO: Ingenic JZ47xx: Add touchscreen mode.

Andy Shevchenko
2020-04-17T21:13:33Z

On Sat, Apr 18, 2020 at 12:05 AM Paul Cercueil <paul@crapouillou.net> wrote:
> Le ven. 17 avril 2020 à 23:59, Andy Shevchenko
> <andy.shevchenko@gmail.com> a écrit :
> > On Fri, Apr 17, 2020 at 11:21 PM Artur Rojek <contact@artur-rojek.eu>
> > wrote:

...

> >> + irq = platform_get_irq(pdev, 0);
> >
> > Before it worked w/o IRQ, here is a regression you introduced.
>
> Before it simply did not need the IRQ, which is provided by the
> devicetree anyway. No regression here.

Does it work without IRQ? Or it was a dead code till now?
For me it's clear regression. Otherwise something is really wrong in a
process of development of this driver.

> >> + if (irq < 0) {
> >
> >> + dev_err(dev, "Failed to get irq: %d\n", irq);
> >
> > Redundant message.
> >
> >> + return irq;
> >> + }

--
With Best Regards,
Andy Shevchenko