Re: [PATCH v4 2/3] iio: adc: ad9467: sort header includes

[Tomas Melin <tomas.melin@vaisala.com>]

On 09/12/2025 16:41, Andy Shevchenko wrote:
> On Tue, Dec 9, 2025 at 7:34 AM Tomas Melin <tomas.melin@vaisala.com> wrote:
>>
>> Include headers in ascending order.
> 
> Thanks, but...
> 
>>  #include <linux/iio/backend.h>
>>  #include <linux/iio/iio.h>
>>  #include <linux/iio/sysfs.h>
> 
> ...this was specifically grouped to show the relation to the certain
> subsystem. At the end we should have something like this
> 
> linux/*.h // generic ones
> ...blank line...
> asm/*.h // generic ones (optionally, if there is a need in a such)
> ...blank line...
> linux/iio/*.h
> ...blank line...

Thanks for the clarification. Sure, it's not a big deal to do a new
version. But FWIW, that convention is not AFAIS explicitly stated
anywhere and with even recent drivers not all following it, it's
somewhat hard to know what expected formatting should be.
It would really be good to have that documented somewhere.

Thanks,
Tomas


> 
> So, what I meant with fixing clk.h is just to move it to the main
> group and sort that.
> 
> You can check (recent enough) drivers for the examples. Yes, some of
> them (but minority IIRC) might have linux/iio/*.h among linux/*.h, but
> usually they are grouped separately.
>