From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1289F35BDC6; Fri, 19 Dec 2025 15:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159461; cv=none; b=qCS8xH4mzl3VhNfcLxV8G3NK86LQ7XsN2Y5xBCX25ODmU6zzK1tve4xXR/sdM61njYQtr+7PsJzZTyU9Usti6VBy9lduDtK3MaUT5Cx53sUNzaWiSZQxTwZ5Zaa/RUdQsOISO6DqqkaCYwG7+duNVqh3LqrMlPMtodLJGkgK+qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159461; c=relaxed/simple; bh=ECixEB5vR8WOwJfTX1zOhq2Kg4Wi8uKygBEwL4mEW6c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OiHOS36RmmyXwlL3sUHQ1ahApWQq3vsrkK2Fkov18YEpGkLX6dcD6gd+SFgx58TaWScBI20dMLN52KUHOt08E1QReLX011lDEvTonV2fx6xS6zfkN8sUVSwSt5dbC6m/q2WQLC11T3HRWG6gFjGKmVDZOHvZR5jogdTJ4Fjpze4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GNjjTnv7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GNjjTnv7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD06EC113D0; Fri, 19 Dec 2025 15:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766159460; bh=ECixEB5vR8WOwJfTX1zOhq2Kg4Wi8uKygBEwL4mEW6c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GNjjTnv7g/GngOKuT190RJE64h4jw0VHuSD7p7VvZPvFQOSPMgHt+kfUrtnz61cIz i2/uK0DrLhk4Tc9k3yZsAG3m1xKvL9HkgRqlTlgnWVbu+Dw9ggutas+eR3jVsU3GCH 1iyzIwvtcOmAt1n0X7+XVvsN4w7D0oMUd7GCoyaB/IaN33DxDQilKXGPsgz6qwtUEB q304qcdnM3LAJ8uNMBlf3nGAfKzW0dj5jT94xxAyDQKT9zP3oktCflnZJKoIs/+0Nl kcwC7p7b157oRYxK08SKXYQ1PCrFWwDhhNHYYdNuUU8clBXdRTy27nTI0F0klBkCHi VuYcSuQsJT2oQ== Message-ID: <7ea6cb11-b9a7-4944-bfa1-63c063eb421e@kernel.org> Date: Fri, 19 Dec 2025 16:50:47 +0100 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: iio: dac: Add max22007 To: Janani Sunil , Lars-Peter Clausen , Michael Hennerich , Alexandru Ardelean , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20251219-max22007-dev-v1-0-242da2c2b868@analog.com> <20251219-max22007-dev-v1-1-242da2c2b868@analog.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251219-max22007-dev-v1-1-242da2c2b868@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2025 16:31, Janani Sunil wrote: > Devicetree bindings for MAX22007 4-channel > 12-bit DAC that drives a voltage or current > output on each channel Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Janani Sunil > --- > .../devicetree/bindings/iio/dac/adi,max22007.yaml | 116 +++++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 123 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml > new file mode 100644 > index 000000000000..c2f65d9e42d4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/adi,max22007.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX22007 DAC device driver Bindings are for hardware, drop all device driver references. > + > +maintainers: > + - Janani Sunil > + > +description: > + The MAX22007 is a quad-channel, 12-bit digital-to-analog converter (DAC) > + with integrated precision output amplifiers and current output capability. > + Each channel can be independently configured for voltage or current output. > + Datasheet available at https://www.analog.com/en/products/max22007.html > + > +$ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: adi,max22007 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 500000 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + vdd-supply: > + description: Low-Voltage Power Supply from +2.7V to +5.5V. > + > + hvdd-supply: > + description: > + Positive High-Voltage Power Supply from +8V to (HVSS +24V) for > + the Output Channels. > + > + hvss-supply: > + description: > + Negative High-Voltage Power Supply from -2V to 0V for the Output Channels. > + > + reset-gpios: > + maxItems: 1 > + description: > + GPIO used for hardware reset of the device. Drop description, redundant, because not saying anything other than schema already said. You could say whether it is active low for example if you wanted to add something useful. > + > +patternProperties: > + "^channel@[0-3]$": > + allOf: > + - $ref: /schemas/iio/dac/dac.yaml# > + - type: object Drop allOf. I don't get where did you get this syntax, it's not needed. > + description: > + Represents the external channels which are connected to the DAC. > + Channels not specified in the device tree will be powered off. > + > + properties: > + reg: > + description: Channel number > + maxItems: 1 > + > + adi,type: > + description: Channel output type. > + $ref: /schemas/types.yaml#/definitions/string > + enum: [voltage, current] Why would it matter if this is voltage or current? That's the first time this property appears. Why none of existing fit? > + > + required: > + - reg > + - adi,type > + > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +anyOf: > + - required: [channel@0] > + - required: [channel@1] > + - required: [channel@2] > + - required: [channel@3] > + > +unevaluatedProperties: false Best regards, Krzysztof