From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34891 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426570AbdD3Qfw (ORCPT ); Sun, 30 Apr 2017 12:35:52 -0400 Subject: Re: [PATCH 4/7] iio: adc: twl4030: Unexport twl4030_madc_conversion() To: Sebastian Reichel , Sebastian Reichel , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jean Delvare , Guenter Roeck Cc: J Keerthy , linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170427153012.32310-1-sebastian.reichel@collabora.co.uk> <20170427153012.32310-5-sebastian.reichel@collabora.co.uk> From: Jonathan Cameron Message-ID: <7eb96b68-71a7-361f-d14c-542a823f96b8@kernel.org> Date: Sun, 30 Apr 2017 17:35:47 +0100 MIME-Version: 1.0 In-Reply-To: <20170427153012.32310-5-sebastian.reichel@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 27/04/17 16:30, Sebastian Reichel wrote: > All madc users have been converted to IIO API, so drop the > legacy API. The function is still used inside of the driver. > > Signed-off-by: Sebastian Reichel Acked-by: Jonathan Cameron > --- > drivers/iio/adc/twl4030-madc.c | 5 +++-- > include/linux/i2c/twl4030-madc.h | 2 -- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 88e44066ef82..be60f76d1a50 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -72,6 +72,8 @@ struct twl4030_madc_data { > u8 isr; > }; > > +static int twl4030_madc_conversion(struct twl4030_madc_request *req); > + > static int twl4030_madc_read(struct iio_dev *iio_dev, > const struct iio_chan_spec *chan, > int *val, int *val2, long mask) > @@ -568,7 +570,7 @@ static int twl4030_madc_wait_conversion_ready(struct twl4030_madc_data *madc, > * be a negative error value in the corresponding array element. > * returns 0 if succeeds else error value > */ > -int twl4030_madc_conversion(struct twl4030_madc_request *req) > +static int twl4030_madc_conversion(struct twl4030_madc_request *req) > { > const struct twl4030_madc_conversion_method *method; > int ret; > @@ -640,7 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) > > return ret; > } > -EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > /** > * twl4030_madc_set_current_generator() - setup bias current > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h > index 0c919ebb31e0..be9260e261ac 100644 > --- a/include/linux/i2c/twl4030-madc.h > +++ b/include/linux/i2c/twl4030-madc.h > @@ -141,6 +141,4 @@ struct twl4030_madc_user_parms { > int status; > u16 result; > }; > - > -int twl4030_madc_conversion(struct twl4030_madc_request *conv); > #endif >