From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:41419 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227AbcHOPOM (ORCPT ); Mon, 15 Aug 2016 11:14:12 -0400 Subject: Re: [PATCH 1/3] iio: chemical: atlas-ph-sensor: switch to iio_device_*_direct_mode helpers To: Matt Ranostay , linux-iio@vger.kernel.org References: <1470798359-4919-1-git-send-email-mranostay@gmail.com> <1470798359-4919-2-git-send-email-mranostay@gmail.com> From: Jonathan Cameron Message-ID: <8067f895-6ab3-9c40-f127-bc74da295f97@kernel.org> Date: Mon, 15 Aug 2016 16:14:11 +0100 MIME-Version: 1.0 In-Reply-To: <1470798359-4919-2-git-send-email-mranostay@gmail.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/08/16 04:05, Matt Ranostay wrote: > Signed-off-by: Matt Ranostay > --- > drivers/iio/chemical/atlas-ph-sensor.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c > index ae038a59d256..8e39b37a5385 100644 > --- a/drivers/iio/chemical/atlas-ph-sensor.c > +++ b/drivers/iio/chemical/atlas-ph-sensor.c > @@ -402,7 +402,9 @@ static int atlas_read_raw(struct iio_dev *indio_dev, > case IIO_PH: > case IIO_CONCENTRATION: > case IIO_ELECTRICALCONDUCTIVITY: > - mutex_lock(&indio_dev->mlock); > + ret = iio_device_claim_direct_mode(indio_dev); > + if (ret) > + return ret; > > if (iio_buffer_enabled(indio_dev)) > ret = -EBUSY; The claim_direct_mode helpers also perform this check... > @@ -410,7 +412,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev, > ret = atlas_read_measurement(data, > chan->address, ®); > > - mutex_unlock(&indio_dev->mlock); > + iio_device_release_direct_mode(indio_dev); > break; > default: > ret = -EINVAL; >