Linux IIO development
 help / color / mirror / Atom feed
From: Dmitry Perchanov <dmitry.perchanov@intel.com>
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, demisrael@gmail.com,
	Dmitry Perchanov <dmitry.perchanov@intel.com>
Subject: [PATCH] iio: hid: fix the retval in [accel|gyro]_3d_capture_sample
Date: Mon, 02 Jan 2023 20:51:27 +0200	[thread overview]
Message-ID: <80a61ea3eb5d00febdaf24ab27e3301fd8c70f74.camel@intel.com> (raw)

From d12f607f83c0bdae6529d8cfbb0cf17f8920c380 Mon Sep 17 00:00:00 2001
From: Dmitry Perchanov <dmitry.perchanov@intel.com>
Date: Tue, 13 Dec 2022 17:44:01 +0200
Subject: [PATCH] iio: hid: fix the retval in [accel|gyro]_3d_capture_sample

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 1 +
 drivers/iio/gyro/hid-sensor-gyro-3d.c   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index a2def6f93..5eac7ea19 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -280,6 +280,7 @@ static int accel_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 			hid_sensor_convert_timestamp(
 					&accel_state->common_attributes,
 					*(int64_t *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 8f0ad022c..698c50da1 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -231,6 +231,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 		gyro_state->timestamp =
 			hid_sensor_convert_timestamp(&gyro_state->common_attributes,
 						     *(s64 *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;
-- 
2.39.0


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


             reply	other threads:[~2023-01-02 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 18:51 Dmitry Perchanov [this message]
2023-01-08 12:24 ` [PATCH] iio: hid: fix the retval in [accel|gyro]_3d_capture_sample Jonathan Cameron
2023-01-08 12:32   ` Jonathan Cameron
2023-01-09  7:46     ` Dmitry Perchanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80a61ea3eb5d00febdaf24ab27e3301fd8c70f74.camel@intel.com \
    --to=dmitry.perchanov@intel.com \
    --cc=demisrael@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox