From: Jonathan Cameron <jic23@kernel.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] drivers: iio: replace comma with a semicolon
Date: Thu, 30 Mar 2017 19:16:51 +0100 [thread overview]
Message-ID: <8151b453-3ae7-7321-8294-c5c8e1cf7a29@kernel.org> (raw)
In-Reply-To: <20170330124121.GA29095@arushi-HP-Pavilion-Notebook>
On 30/03/17 13:41, Arushi Singhal wrote:
> Replace a comma between expression statements by a semicolon. This
> changes the semantics of the code, but given the current indentation
> appears to be what is intended.
> A simplified version of the Coccinelle semantic patch that performs this
> transformation is as follows:
>
> // <smpl>
> @r@
> expression e1,e2;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
As per the discussion about the other one. This is perfectly
correct, but weird enough that I think we'll clear it out.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
I did add chemical to the title though to make it clearer what
this was covering.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/ams-iaq-core.c | 2 +-
> drivers/iio/chemical/vz89x.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/ams-iaq-core.c b/drivers/iio/chemical/ams-iaq-core.c
> index 41a8e6f2e31d..c948ad2ee9ad 100644
> --- a/drivers/iio/chemical/ams-iaq-core.c
> +++ b/drivers/iio/chemical/ams-iaq-core.c
> @@ -163,7 +163,7 @@ static int ams_iaqcore_probe(struct i2c_client *client,
> mutex_init(&data->lock);
>
> indio_dev->dev.parent = &client->dev;
> - indio_dev->info = &ams_iaqcore_info,
> + indio_dev->info = &ams_iaqcore_info;
> indio_dev->name = dev_name(&client->dev);
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> index 8e0e4415c161..f75eea6822f2 100644
> --- a/drivers/iio/chemical/vz89x.c
> +++ b/drivers/iio/chemical/vz89x.c
> @@ -393,7 +393,7 @@ static int vz89x_probe(struct i2c_client *client,
> mutex_init(&data->lock);
>
> indio_dev->dev.parent = &client->dev;
> - indio_dev->info = &vz89x_info,
> + indio_dev->info = &vz89x_info;
> indio_dev->name = dev_name(&client->dev);
> indio_dev->modes = INDIO_DIRECT_MODE;
>
>
next prev parent reply other threads:[~2017-03-30 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 12:41 [PATCH] drivers: iio: replace comma with a semicolon Arushi Singhal
2017-03-30 18:16 ` Jonathan Cameron [this message]
2017-03-30 18:34 ` Arushi Singhal
2017-04-02 9:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8151b453-3ae7-7321-8294-c5c8e1cf7a29@kernel.org \
--to=jic23@kernel.org \
--cc=arushisinghal19971997@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox