Re: [PATCH 0/4] iio: accel: Share ACPI ROTM parsing between drivers and add it to mxc4005

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 4/22/24 9:55 AM, Andy Shevchenko wrote:
> Wed, Apr 17, 2024 at 06:46:12PM +0200, Hans de Goede kirjoitti:
>> Hi All,
>>
>> Here is a patch series to refactor the ACPI ROTM orientation matrix
>> handling in kxcjk-1013 + bmc150-accel to share the code instead of
>> having 2 copies and then also use the shared implementation in
>> the mxc4005 driver since some MXC6655 ACPI firmware nodes also
>> include this.
>>
>> Note the mxc4005 support is untested, I will ask the report of:
> 
> I have briefly looked into this and I like this, except the part of the big
> function being in the header. Why? Why can't it be in a C-file?
> 
> Note, 3 users justify very well to me that shared code, should be shared in
> binary as well. (I.o.w. you may argue that IRL there will be no more than
> one of such device connected, but in case of DIY and prototyping it might
> still be the use case.)

It is only 1 function and it is not that big. IMHO the static inline
in a header solution here is much better then making this a separate .ko
file with all the associated overhead.

Regards,

Hans