From: "Nuno Sá" <noname.nuno@gmail.com>
To: Fabrizio Lamarque <fl.scratchpad@gmail.com>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 2/3] iio: adc: ad7192: Fix internal/external clock selection
Date: Thu, 13 Apr 2023 12:04:05 +0200 [thread overview]
Message-ID: <8217129cb69c180bae1d3d839eed403c3b40e07b.camel@gmail.com> (raw)
In-Reply-To: <CAPJMGm4YhDNOLku_vWUJA8cYbUinoVoP+NmP4Te+fpa-bjfHfQ@mail.gmail.com>
On Thu, 2023-04-13 at 10:33 +0200, Fabrizio Lamarque wrote:
> Fixed wrong selection of internal clock when mclk is defined.
>
> Resolved a logical inversion introduced in c9ec2cb328e3.
>
> Fixes: c9ec2cb328e3 iio: adc: ad7192: use devm_clk_get_optional() for mclk
ditto...
> Signed-off-by: Fabrizio Lamarque <fl.scratchpad@gmail.com>
> ---
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> drivers/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 94a9cf34a255..5a9c8898f8af 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -367,7 +367,7 @@ static int ad7192_of_clock_select(struct ad7192_state *st)
> clock_sel = AD7192_CLK_INT;
>
> /* use internal clock */
> - if (st->mclk) {
> + if (!st->mclk) {
> if (of_property_read_bool(np, "adi,int-clock-output-enable"))
> clock_sel = AD7192_CLK_INT_CO;
> } else {
next prev parent reply other threads:[~2023-04-13 10:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 8:26 [PATCH v2 0/3] iio: adc: ad7192: Functional fixes Fabrizio Lamarque
2023-04-13 8:28 ` [PATCH v2 1/3] iio: adc: ad7192: Fix null pointer dereference on probe Fabrizio Lamarque
2023-04-13 8:33 ` [PATCH 2/3] iio: adc: ad7192: Fix internal/external clock selection Fabrizio Lamarque
2023-04-13 8:36 ` [PATCH 3/3] iio: adc: ad7192: Clarify binding documentation Fabrizio Lamarque
2023-04-13 10:15 ` Nuno Sá
2023-04-13 10:47 ` Fabrizio Lamarque
2023-04-13 11:23 ` Nuno Sá
2023-04-13 14:21 ` Krzysztof Kozlowski
2023-04-13 16:07 ` Fabrizio Lamarque
2023-04-13 16:35 ` Krzysztof Kozlowski
2023-04-13 18:19 ` Fabrizio Lamarque
2023-04-14 9:18 ` Krzysztof Kozlowski
2023-04-14 10:42 ` Fabrizio Lamarque
2023-04-15 16:38 ` Jonathan Cameron
2023-04-26 10:45 ` Fabrizio Lamarque
2023-05-01 16:03 ` Jonathan Cameron
2023-04-13 10:04 ` Nuno Sá [this message]
2023-04-15 16:39 ` [PATCH 2/3] iio: adc: ad7192: Fix internal/external clock selection Jonathan Cameron
2023-04-13 10:03 ` [PATCH v2 1/3] iio: adc: ad7192: Fix null pointer dereference on probe Nuno Sá
2023-04-15 16:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8217129cb69c180bae1d3d839eed403c3b40e07b.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=fl.scratchpad@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox