From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions To: Peter Meerwald-Stadler , linux-iio@vger.kernel.org Cc: Jonathan Cameron , LKML , kernel-janitors@vger.kernel.org References: <20171026170913.5ff10718@archlinux> From: SF Markus Elfring Message-ID: <82e2fde9-2b35-be54-4614-977fc2894da1@users.sourceforge.net> Date: Fri, 27 Oct 2017 14:37:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: >> But I proposed an other source code layout for useful reasons. > > I think there is a (hidden) cost of having pure cleanup patches: > they make backporting fixes harder (across the cleanup) There the usual software development consequences to consider if you dare to change the source code at all. > stylistic changes must have a clear benefit, readability is subjective, > consistency per se doesn't buy anything There are also different opinions involved. > the discussion how code should be written in the first place is separate > from the discussion what is worth fixing up lateron (IMHO) Are you looking for a corresponding agreement? Regards, Markus