Linux IIO development
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
	Nuno Sa <nuno.sa@analog.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	oe-kbuild@lists.linux.dev, lkp@intel.com,
	oe-kbuild-all@lists.linux.dev,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: set_bit() takes a bit number
Date: Mon, 06 Nov 2023 16:16:09 +0100	[thread overview]
Message-ID: <8371368263aea64bc0f635f723cb6ca9d0176dea.camel@gmail.com> (raw)
In-Reply-To: <41eff9b4-3041-4a1e-ba28-b16d866cd894@intel.com>

On Mon, 2023-11-06 at 14:39 +0100, Alexander Lobakin wrote:
> From: Nuno Sá <noname.nuno@gmail.com>
> Date: Mon, 06 Nov 2023 13:02:58 +0100
> 
> > On Mon, 2023-11-06 at 12:18 +0100, Alexander Lobakin wrote:
> > > From: Nuno Sá <noname.nuno@gmail.com>
> > > Date: Mon, 06 Nov 2023 11:07:16 +0100
> 
> [...]
> 
> > > assign_bit() does not take a bitmask as a first argument, but a bit number.
> > > 
> > > I.e. if you want to switch BIT(0), you call it like assign_bit(0, ...),
> > > not assign_bit(BIT(0), ...). Same for the bit nr 1.
> > > 
> > 
> > Yes, I know... if you look at my reply to Dan you can see I realized that already
> > :) 
> 
> Oh okay :)
> 
> > 
> > I guess by the time I first sent this time I didn't knew or maybe just a dumb
> > mistake...
> > 
> > I'll send a patch later today removing the BIT() from the #define, thx!
> 
> Nice! Don't forget the tags the build bot asked for :p
> 

Just sent it... Hopefully no tags were forgotten! I was not sure about the Fixes tag
but added it anyways as this is indeed fixing something (even though the bug was
never triggered).

- Nuno Sá


      reply	other threads:[~2023-11-06 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ff4ef031-774e-4e4d-a009-31f242bf6aee@kadam.mountain>
2023-11-06  9:31 ` [alobakin:pfcp 5/20] drivers/iio/imu/adis16475.c:363 adis16475_set_freq() warn: set_bit() takes a bit number Alexander Lobakin
2023-11-06 10:07   ` Nuno Sá
2023-11-06 11:18     ` Alexander Lobakin
2023-11-06 12:02       ` Nuno Sá
2023-11-06 13:39         ` Alexander Lobakin
2023-11-06 15:16           ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8371368263aea64bc0f635f723cb6ca9d0176dea.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nuno.sa@analog.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=oe-kbuild@lists.linux.dev \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox