From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Gazzillo <paul@pgazz.com>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306
Date: Tue, 10 Oct 2023 22:48:43 +1030 [thread overview]
Message-ID: <83bb2425-aff1-6359-37f4-4182d4f8ed05@tweaklogic.com> (raw)
In-Reply-To: <2c6ff28f-9031-beb2-f8d0-e7f12b0a07b4@gmail.com>
On 10/10/23 19:22, Matti Vaittinen wrote:
>> +properties:
>> + compatible:
>> + const: avago,apds9306
>
> I see the driver supports two different variants of this IC, differentiated by the part-ID register. Variants are named as apds9306 and apds9306-065. I wonder if we could/should have different compatibles for them?
>
Yes, we can. It makes sense. I'll implement that.
Regards,
Subhajit Ghosh
next prev parent reply other threads:[~2023-10-10 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 15:48 [PATCH 0/2] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2023-10-08 15:48 ` [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-09 8:36 ` Krzysztof Kozlowski
2023-10-09 11:25 ` Subhajit Ghosh
2023-10-10 8:52 ` Matti Vaittinen
2023-10-10 12:18 ` Subhajit Ghosh [this message]
2023-10-10 14:49 ` Jonathan Cameron
2023-10-10 16:19 ` Rob Herring
2023-10-11 13:04 ` Subhajit Ghosh
2023-10-10 13:51 ` Jonathan Cameron
2023-10-11 13:10 ` Subhajit Ghosh
2023-10-08 15:48 ` [PATCH 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-10 9:45 ` Matti Vaittinen
2023-10-10 12:17 ` Subhajit Ghosh
2023-10-10 14:38 ` Jonathan Cameron
2023-10-11 14:37 ` Subhajit Ghosh
2023-10-12 7:54 ` Jonathan Cameron
2023-10-12 12:37 ` Subhajit Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bb2425-aff1-6359-37f4-4182d4f8ed05@tweaklogic.com \
--to=subhajit.ghosh@tweaklogic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox