From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marek Vasut <marex@denx.de>, Anshul Dalal <anshulusr@gmail.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Matt Ranostay <matt@ranostay.sg>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property vdd-supply
Date: Thu, 8 Feb 2024 21:10:25 +1030 [thread overview]
Message-ID: <84591019-6958-4685-8830-54260aadd26b@tweaklogic.com> (raw)
In-Reply-To: <dbfde067-50b8-4f86-a098-0fc160114854@linaro.org>
Hi Krzysztof,
On 8/2/24 18:47, Krzysztof Kozlowski wrote:
> On 06/02/2024 14:00, Subhajit Ghosh wrote:
>> Add vdd-supply property which is valid and useful for all the
>> devices in this schema.
>
> Why is it useful? How is it useful? DT describes the hardware, not
> because something is "useful".
I am adding this property based on a previous review:
https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/
Does the below commit message in this context make sense to you?
"Add vdd-supply property for all the devices in this schema."
>
>>
>> this patch depends on patch:
>> "dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas"
>
> This is unrelated and does not make any sense in commit msg. Drop.
Apologies for the silly questions:
What does the "Drop" signify? Are you asking me to drop/delete the above
"...patch depends..." message or does it have any other meaning?
In the next version, do I include the ack tag by Conor for this commit?
>
>
> Best regards,
> Krzysztof
>
Thank you for reviewing.
Regards,
Subhajit Ghosh
next prev parent reply other threads:[~2024-02-08 10:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:00 [PATCH v6 0/5] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2024-02-06 13:00 ` [PATCH v6 1/5] dt-bindings: iio: light: Merge APDS9300 and APDS9960 schemas Subhajit Ghosh
2024-02-06 13:00 ` [PATCH v6 2/5] dt-bindings: iio: light: adps9300: Add property vdd-supply Subhajit Ghosh
2024-02-08 8:17 ` Krzysztof Kozlowski
2024-02-08 10:40 ` Subhajit Ghosh [this message]
2024-02-09 7:33 ` Krzysztof Kozlowski
2024-02-10 17:01 ` Jonathan Cameron
2024-02-06 13:00 ` [PATCH v6 3/5] dt-bindings: iio: light: adps9300: Update interrupt definitions Subhajit Ghosh
2024-02-08 8:18 ` Krzysztof Kozlowski
2024-02-08 10:53 ` Subhajit Ghosh
2024-02-10 17:02 ` Jonathan Cameron
2024-02-06 13:00 ` [PATCH v6 4/5] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2024-02-08 8:18 ` Krzysztof Kozlowski
2024-02-08 10:51 ` Subhajit Ghosh
2024-02-08 18:52 ` Conor Dooley
2024-02-09 7:34 ` Krzysztof Kozlowski
2024-02-06 13:00 ` [PATCH v6 5/5] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2024-02-06 13:42 ` Andy Shevchenko
2024-02-07 11:07 ` Subhajit Ghosh
2024-02-07 14:53 ` Andy Shevchenko
2024-02-06 14:47 ` [PATCH v6 0/5] Support for Avago APDS9306 Ambient " Conor Dooley
2024-02-07 10:39 ` Subhajit Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84591019-6958-4685-8830-54260aadd26b@tweaklogic.com \
--to=subhajit.ghosh@tweaklogic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=matt@ranostay.sg \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox