From: Marek Vasut <marek.vasut@gmail.com>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH] iio: adc: Add Renesas GyroADC driver
Date: Fri, 30 Dec 2016 22:49:37 +0100 [thread overview]
Message-ID: <84a65f76-b82a-030b-a527-ee23d9ad25a8@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1612302205210.3977@pmeerw.net>
On 12/30/2016 10:09 PM, Peter Meerwald-Stadler wrote:
>
>>>> Add IIO driver for the Renesas RCar GyroADC block. This block is a
>>>> simple 4/8-channel ADC which samples 12/15/24 bits of data every
>
>>>> + if (iio_buffer_enabled(indio_dev))
>>>> + return -EBUSY;
>>>
>>> use iio_device_claim_direct_mode()
>>
>> Why ? Do I really need the mutex locking here ?
>
> no, not needed, since you do not support buffered mode yet; but neither do
> you need iio_buffer_enabled()
>
> p.
>
So drop the whole thing then ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-12-30 21:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 19:18 [PATCH] iio: adc: Add Renesas GyroADC driver Marek Vasut
2016-12-30 19:50 ` Peter Meerwald-Stadler
2016-12-30 20:52 ` Marek Vasut
2016-12-30 21:09 ` Peter Meerwald-Stadler
2016-12-30 21:49 ` Marek Vasut [this message]
2017-01-02 10:01 ` Geert Uytterhoeven
2017-01-04 14:27 ` Marek Vasut
2017-01-04 20:36 ` Geert Uytterhoeven
2017-01-04 21:19 ` Marek Vasut
2017-01-04 21:36 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a65f76-b82a-030b-a527-ee23d9ad25a8@gmail.com \
--to=marek.vasut@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).