Re: [PATCH] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999.

[Florian Boor <florian.boor@kernelconcepts.de>]

Hi,

On 05.09.21 13:26, Jonathan Cameron wrote:
> On Mon, 30 Aug 2021 16:59:34 +0200
> Normal convention on this (not helped here by the complete lack of
> a binding document for this device) would be that the driver would
> use the external vref is vref-supply is present.
> 
> Currently the driver uses devm_regulator_get().  In this case it
> should be using devm_regulator_get_optional() as that will avoid a
> 'fake' regulator being provided.  

okay right - in this case we could get rid of the additional setting and only if
there is no vref-supply provided we need to get a dummy.

> The driver will need a few changes to handle the possible error return
> from that call, but it shouldn't be too complicated.

I'll send an updated patch...

> If you are willing it would be great to have a binding description for
> this driver. I'm no sure how it has slipped through the net for so long!

I'll add this as well.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49(0) 271-338857-15
and the reality of tomorrow.		Fax: +49(0) 271-338857-29
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

kernel concepts GmbH
Hauptstraße 16
57074 Siegen
Deutschland
Geschäftsführer: Ole Reinhardt
HR Siegen, HR B 9613