From: ASSI <Stromeko@nexgo.de>
To: linux-iio@vger.kernel.org
Subject: Re: [bmp280 v1 3/6] iio: pressure: bmp280: implement sampling_frequency for BMx280
Date: Mon, 04 Aug 2025 19:29:48 +0200 [thread overview]
Message-ID: <874iunknar.fsf@Gerda.invalid> (raw)
In-Reply-To: CAHp75VfhzJrPU6E=potYqPDYMbimhOy7edw9U0MfKsYMYwo8Sw@mail.gmail.com
Andy Shevchenko writes:
>> + .sampling_freq_default = BMP280_ODR_0HZ, /* MODE_FORCED */
>
> Why is this comment repeated all over the code? Any justification why
> it's so important, please?
It's just a reminder that this value isn't actually used by the driver
to do what it says in the datasheet, but instead for effecting the
switching between MODE_FORCED and MODE_NORMAL. If you'd really want to
run the sensor with no standby between measurements there'd need to be
an extra invalid value (like -1), that then would need to be guarded
everywhere against getting used as an array index.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
next prev parent reply other threads:[~2025-08-04 17:29 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 23:30 [PATCH v9 0/4] pressure: bmp280: Minor cleanup and interrupt support Vasileios Amoiridis
2024-10-17 23:30 ` [PATCH v9 1/4] iio: pressure: bmp280: Use sleep and forced mode for oneshot captures Vasileios Amoiridis
2025-06-28 18:45 ` ASSI
2025-06-28 20:57 ` David Lechner
2025-06-29 7:43 ` ASSI
2025-07-11 19:17 ` ASSI
2025-07-12 14:49 ` ASSI
2025-07-21 19:15 ` ASSI
2025-07-26 18:34 ` ASSI
2025-07-27 19:08 ` ASSI
2024-10-17 23:30 ` [PATCH v9 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices Vasileios Amoiridis
2024-10-17 23:30 ` [PATCH v9 3/4] iio: pressure: bmp280: Add data ready trigger support Vasileios Amoiridis
2024-10-17 23:30 ` [PATCH v9 4/4] iio: pressure: bmp280: Move bmp085 interrupt to new configuration Vasileios Amoiridis
2024-10-19 13:55 ` [PATCH v9 0/4] pressure: bmp280: Minor cleanup and interrupt support Jonathan Cameron
2025-08-03 14:07 ` [bmp280 v1 0/6] Fixes and enhancements for the bmp280 driver Achim Gratz
2025-08-03 14:07 ` [bmp280 v1 1/6] iio: pressure: bmp280: correct meas_time_us calculation Achim Gratz
2025-08-06 15:46 ` Jonathan Cameron
2025-08-06 17:53 ` ASSI
2025-08-10 18:04 ` Jonathan Cameron
2025-08-03 14:07 ` [bmp280 v1 2/6] iio: pressure: bmp280: reduce overhead on read with MODE_FORCED Achim Gratz
2025-08-03 20:12 ` Andy Shevchenko
2025-08-06 15:58 ` Jonathan Cameron
2025-08-06 18:00 ` ASSI
2025-08-03 14:07 ` [bmp280 v1 3/6] iio: pressure: bmp280: implement sampling_frequency for BMx280 Achim Gratz
2025-08-03 20:26 ` Andy Shevchenko
2025-08-04 17:29 ` ASSI [this message]
2025-08-10 18:11 ` Jonathan Cameron
2025-08-10 19:12 ` ASSI
2025-08-11 19:48 ` Jonathan Cameron
2025-08-12 19:53 ` ASSI
2025-08-17 15:10 ` Jonathan Cameron
2025-08-17 16:36 ` ASSI
2025-08-03 14:08 ` [bmp280 v1 4/6] iio: pressure: bmp280: enable filter settings " Achim Gratz
2025-08-03 20:28 ` Andy Shevchenko
2025-08-04 17:14 ` ASSI
2025-08-10 18:13 ` Jonathan Cameron
2025-08-10 19:01 ` ASSI
2025-08-11 20:14 ` Jonathan Cameron
2025-08-12 19:34 ` ASSI
2025-08-17 14:51 ` Jonathan Cameron
2025-08-03 14:08 ` [bmp280 v1 5/6] iio: pressure: bmp280: remove code duplication Achim Gratz
2025-08-03 20:30 ` Andy Shevchenko
2025-08-10 18:19 ` Jonathan Cameron
2025-08-03 14:08 ` [bmp280 v1 6/6] iio: pressure: bmp280: implement sampling_frequency calculation for BMx280 Achim Gratz
2025-08-03 20:37 ` Andy Shevchenko
2025-08-04 17:20 ` ASSI
2025-08-03 19:20 ` [bmp280 v1 0/6] Fixes and enhancements for the bmp280 driver Andy Shevchenko
2025-08-10 18:58 ` [RFC PATCH v2 0/9] " Achim Gratz
2025-08-10 18:58 ` [RFC PATCH v2 1/9] iio: pressure: bmp280: correct meas_time_us calculation Achim Gratz
2025-08-17 15:16 ` Jonathan Cameron
2025-08-10 18:58 ` [RFC PATCH v2 2/9] iio: pressure: bmp280: implement adaptive wait for BMx280 devices Achim Gratz
2025-08-10 19:49 ` Andy Shevchenko
2025-08-16 18:42 ` ASSI
2025-08-10 18:58 ` [RFC PATCH v2 3/9] iio: pressure: bmp280: implement adaptive wait for BMP380 devices Achim Gratz
2025-08-10 18:58 ` [RFC PATCH v2 4/9] iio: pressure: bmp280: refactoring Achim Gratz
2025-08-17 15:23 ` Jonathan Cameron
2025-08-10 18:58 ` [RFC PATCH v2 5/9] iio: pressure: bmp280: remove code duplication Achim Gratz
2025-08-10 18:58 ` [RFC PATCH v2 6/9] iio: pressure: bmp280: enable filter settings for BMx280 Achim Gratz
2025-08-17 16:37 ` Jonathan Cameron
2025-08-10 18:58 ` [RFC PATCH v2 7/9] iio: pressure: bmp280: implement sampling_frequency " Achim Gratz
2025-08-17 16:53 ` Jonathan Cameron
2025-08-17 17:36 ` ASSI
2025-08-10 18:58 ` [RFC PATCH v2 8/9] iio: pressure: bmp280: implement sampling_frequency calculation " Achim Gratz
2025-08-17 17:04 ` Jonathan Cameron
2025-08-17 17:40 ` ASSI
2025-08-18 17:52 ` Jonathan Cameron
2025-08-10 18:58 ` [RFC PATCH v2 9/9] iio: pressure: bmp280: test longer autosuspend (WIP) Achim Gratz
2025-08-17 17:05 ` Jonathan Cameron
2025-08-17 17:44 ` ASSI
2025-08-11 12:14 ` [RFC PATCH v2 0/9] Fixes and enhancements for the bmp280 driver Andy Shevchenko
2025-08-11 20:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iunknar.fsf@Gerda.invalid \
--to=stromeko@nexgo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).