From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: linux-iio@vger.kernel.org, jonathan.cameron@huawei.com,
pmeerw@pmeerw.net, pierre-moana.levesque@parrot.com
Subject: Re: [PATCH v4 2/2] iio: light: isl29501: Add support for the ISL29501 ToF sensor.
Date: Mon, 02 Jul 2018 10:59:01 +0200 [thread overview]
Message-ID: <87in5yt3my.fsf@gmail.com> (raw)
In-Reply-To: <20180630173044.3eac53d2@archlinux>
Hi Jonathan,
> A few minors + some missing docs / possible changes in the use
> of extended_name which is in the category of 'only use this in unusual
> circumstances' as it breaks being able to use generic userspace code.
I'll use the IIO_MOD_LIGHT_CLEAR on IIO_INTENSITY to avoid those
extended_name in v5.
>
> Are we stalled on the floating point support question, or is the
> driver just 'limited' but still useful before we have that resolved?
No I guess the driver is ready to go, the user will just lack the
possibility of displaying/setting intensity values for crosstalk
calibration through the driver.
Thanks for your review,
Mathieu
prev parent reply other threads:[~2018-07-02 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 14:31 [PATCH v4 0/2] Add ISL29501 support Mathieu Othacehe
2018-06-28 14:31 ` [PATCH v4 1/2] iio: Add channel for Phase Mathieu Othacehe
2018-06-28 14:31 ` [PATCH v4 2/2] iio: light: isl29501: Add support for the ISL29501 ToF sensor Mathieu Othacehe
2018-06-30 16:30 ` Jonathan Cameron
2018-07-02 8:59 ` Mathieu Othacehe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in5yt3my.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=jonathan.cameron@huawei.com \
--cc=linux-iio@vger.kernel.org \
--cc=pierre-moana.levesque@parrot.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).