From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C62C43381 for ; Fri, 22 Mar 2019 09:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 335A42190A for ; Fri, 22 Mar 2019 09:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfCVJlp (ORCPT ); Fri, 22 Mar 2019 05:41:45 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:43899 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727713AbfCVJlp (ORCPT ); Fri, 22 Mar 2019 05:41:45 -0400 X-Originating-IP: 109.213.38.144 Received: from localhost (alyon-652-1-47-144.w109-213.abo.wanadoo.fr [109.213.38.144]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id BA75EFF812; Fri, 22 Mar 2019 09:41:42 +0000 (UTC) From: Gregory CLEMENT To: Jonathan Cameron Cc: devicetree@vger.kernel.org, Alexandre Belloni , Lars-Peter Clausen , Thomas Petazzoni , linux-iio@vger.kernel.org, Rob Herring , Peter Meerwald-Stadler , Hartmut Knaack , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add bindings for TI ADS8344 A/DC chips In-Reply-To: <20190316170730.2ed341cc@archlinux> References: <20190315151152.30467-1-gregory.clement@bootlin.com> <20190315151152.30467-2-gregory.clement@bootlin.com> <20190316170730.2ed341cc@archlinux> Date: Fri, 22 Mar 2019 10:41:42 +0100 Message-ID: <87lg17p7op.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Jonathan, On sam., mars 16 2019, Jonathan Cameron wrote: > On Fri, 15 Mar 2019 16:11:50 +0100 > Gregory CLEMENT wrote: > >> This adds device tree bindings for the TI ADS8344 A/DC chips. >> >> Signed-off-by: Gregory CLEMENT > Looks good to me, though io-channel-cells only needs to be 1 if > you have consumers... Otherwise, it shouldn't be there at all.. OK I will remove it then. Thanks, Gregory > > Jonathan > >> --- >> .../bindings/iio/adc/ti-ads8344.txt | 21 +++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt >> new file mode 100644 >> index 000000000000..6576c4fed7b7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt >> @@ -0,0 +1,21 @@ >> +* Texas Instruments ADS8344 A/DC chip >> + >> +Required properties: >> + - compatible: Must be "ti,ads8344" >> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >> + - reg: SPI chip select number for the device >> + - vref-supply: phandle to a regulator node that supplies the >> + reference voltage >> + >> +Recommended properties: >> + - spi-max-frequency: Definition as per >> + Documentation/devicetree/bindings/spi/spi-bus.txt >> + >> +Example: >> +adc@0 { >> + compatible = "ti,ads8344"; >> + reg = <0>; >> + #io-channel-cells = <1>; >> + vref-supply = <&refin_supply>; >> + spi-max-frequency = <10000000>; >> +}; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com