linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Rosin <peda@axentia.se>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	linux-kernel@vger.kernel.org,
	Crestez Dan Leonard <leonard.crestez@intel.com>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: inform the i2c mux core about how it is used
Date: Sat, 3 Sep 2016 17:30:45 +0100	[thread overview]
Message-ID: <8a4804d5-3d92-fff0-e48e-beebfb8ba1e2@kernel.org> (raw)
In-Reply-To: <1472630560-4905-1-git-send-email-peda@axentia.se>

On 31/08/16 09:02, Peter Rosin wrote:
> The i2c mux core can then take appropriate action depending on if it is
> used for an actual i2c mux, or for an arbitrator or gate. In this case
> it is used as a gate.
> 
> This will make devicetree bindings simpler when they are eventually
> added.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> So, this depends on the i2c-mux-dt-3 branch [1] that Jonathan
> pulled to support the new mpu-3050 gyroscope driver. I had
> planned to submit this post 4.9-rc1, but since the iio tree
> got the prerequisite already, I'm sending it right away.
It's not there yet as the mpu-3050 has to go round again
for other reasons.  As such I haven't yet pulled your branch.
This patch isn't going to justify the pull on it's own.

I'll try and remember to pick it up when Linus gets back with
the final mpu-3050 and I pull your tree in.

If not give me a poke!

Jonathan
> 
> Cheers,
> Peter
> 
> [1] https://github.com/peda-r/i2c-mux.git i2c-mux-dt-3
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> index 19580d1db597..2c3f8964a3ea 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> @@ -126,7 +126,7 @@ static int inv_mpu_probe(struct i2c_client *client,
>  
>  	st = iio_priv(dev_get_drvdata(&client->dev));
>  	st->muxc = i2c_mux_alloc(client->adapter, &client->dev,
> -				 1, 0, I2C_MUX_LOCKED,
> +				 1, 0, I2C_MUX_LOCKED | I2C_MUX_GATE,
>  				 inv_mpu6050_select_bypass,
>  				 inv_mpu6050_deselect_bypass);
>  	if (!st->muxc) {
> 


  reply	other threads:[~2016-09-03 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31  8:02 [PATCH] iio: imu: inv_mpu6050: inform the i2c mux core about how it is used Peter Rosin
2016-09-03 16:30 ` Jonathan Cameron [this message]
2016-09-13 20:44   ` Linus Walleij
2016-11-10  9:23   ` Peter Rosin
2016-11-12 14:45     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a4804d5-3d92-fff0-e48e-beebfb8ba1e2@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=leonard.crestez@intel.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).