public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Harpreet Saini <sainiharpreet29@yahoo.com>, jic23@kernel.org
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andreas Klinger" <ak@it-klinger.de>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: Add driver for PixArt PAJ7620
Date: Mon, 13 Apr 2026 09:31:09 -0500	[thread overview]
Message-ID: <8abcc3cf-32e8-4ca2-9c13-9f0c5b1c331e@baylibre.com> (raw)
In-Reply-To: <20260413000946.7880-1-sainiharpreet29@yahoo.com>

On 4/12/26 7:09 PM, Harpreet Saini wrote:
> Signed-off-by: Harpreet Saini <sainiharpreet29@yahoo.com>
> ---
> This is part 2 of a 2-patch series proposing a driver for the PixArt
> PAJ7620 gesture sensor. This patch adds the actual C driver, Kconfig 
> hooks, and Makefile integrations. The device tree bindings were submitted
> in the preceding patch.

Patches should be combined into a series with a cover letter.

The cover letter should explain clearly why this should be considered
for the IIO subsystem instead of the input subsystem. It doesn't seem
like there is a valid justification though.

> 
>  drivers/iio/light/Kconfig   |   7 +
>  drivers/iio/light/Makefile  |   1 +
>  drivers/iio/light/paj7620.c | 433 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 441 insertions(+)
>  create mode 100644 drivers/iio/light/paj7620.c

There is no IIO_LIGHT channel, so this does not look at all like
a light sensor.


      reply	other threads:[~2026-04-13 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260413000946.7880-1-sainiharpreet29.ref@yahoo.com>
2026-04-13  0:09 ` [PATCH] iio: light: Add driver for PixArt PAJ7620 Harpreet Saini
2026-04-13 14:31   ` David Lechner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8abcc3cf-32e8-4ca2-9c13-9f0c5b1c331e@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sainiharpreet29@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox