linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
	linux-iio@vger.kernel.org
Cc: michael.hennerich@analog.com, jic23@kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ad7791: implement IIO_CHAN_INFO_SAMP_FREQ
Date: Mon, 12 Mar 2018 13:56:06 +0100	[thread overview]
Message-ID: <8c3ee9d4-fc17-653e-ab4e-94ca2bffc50c@metafoo.de> (raw)
In-Reply-To: <20180312120654.1806-2-alexandru.ardelean@analog.com>

On 03/12/2018 01:06 PM, Alexandru Ardelean wrote:
[...]
> +		for (i = 0; i < ARRAY_SIZE(ad7791_sample_freq_avail); i++) {
> +			if (ad7791_sample_freq_avail[i][0] == val &&
> +			    ad7791_sample_freq_avail[i][1] == val2)
> +				break;
> +		}

Unrelated to this patch. But we should really add a helper function for
looking up entries in these val,val2 arrays.

[...]


  reply	other threads:[~2018-03-12 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 12:06 [PATCH 1/2] iio: adc: ad7791: remove sample freq sysfs attributes Alexandru Ardelean
2018-03-12 12:06 ` [PATCH 2/2] iio: adc: ad7791: implement IIO_CHAN_INFO_SAMP_FREQ Alexandru Ardelean
2018-03-12 12:56   ` Lars-Peter Clausen [this message]
2018-03-17 20:48   ` Jonathan Cameron
2018-03-17 20:44 ` [PATCH 1/2] iio: adc: ad7791: remove sample freq sysfs attributes Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c3ee9d4-fc17-653e-ab4e-94ca2bffc50c@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alexandru.ardelean@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).