From: Jonathan Cameron <jic23@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Gregor Boirie <gregor.boirie@parrot.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hornung <mhornung.linux@gmail.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Alexander Koch <mail@alexanderkoch.net>
Subject: Re: [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases
Date: Sat, 21 Jan 2017 14:22:26 +0000 [thread overview]
Message-ID: <8e240655-dfb0-6c8a-b5c5-0c671a579ea4@kernel.org> (raw)
In-Reply-To: <1484581845-19457-1-git-send-email-javier@osg.samsung.com>
On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
>
> drivers/iio/light/opt3001.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> index 78c9b3a6453a..b91ebc3483ce 100644
> --- a/drivers/iio/light/opt3001.c
> +++ b/drivers/iio/light/opt3001.c
> @@ -840,6 +840,7 @@ static const struct of_device_id opt3001_of_match[] = {
> { .compatible = "ti,opt3001" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, opt3001_of_match);
>
> static struct i2c_driver opt3001_driver = {
> .probe = opt3001_probe,
>
prev parent reply other threads:[~2017-01-21 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 15:50 [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 15:50 ` [PATCH 2/3] iio: potentiometer: mcp4531: " Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-16 15:50 ` [PATCH 3/3] iio: adc: max1363: " Javier Martinez Canillas
2017-01-21 14:22 ` Jonathan Cameron
2017-01-21 14:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e240655-dfb0-6c8a-b5c5-0c671a579ea4@kernel.org \
--to=jic23@kernel.org \
--cc=gregor.boirie@parrot.com \
--cc=javier@osg.samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=mhornung.linux@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).