From: Subhajit Ghosh <subhajit.ghosh@vixtechnology.com>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: jic23@kernel.org, lars@metafoo.de, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: apds9960: Fix iio_event_spec structures
Date: Fri, 11 Nov 2022 15:04:08 +0800 [thread overview]
Message-ID: <91e0ffc5-6517-c045-7bac-0b8d904822b9@vixtechnology.com> (raw)
In-Reply-To: <CAJCx=g=WaGiBFYJTTjNgzrnW3We0qpuMvyy9iFAVDC8Mkbscsg@mail.gmail.com>
>>
>
> Hmm maybe Jonathan will have some feedback on this (and if it is okay
> to break the ABI interface). Been awhile since I've touched
> this driver and a little rusty on iio events. But I am guessing your
> method makes sense since the event(s) has direction and a type, and
> can't just have one of the .mask_shared_by_dir and mask_shared_by_type.
>
> In any case:
>
> Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
Thank you so much for your time and review Matt.
Apologies for the company disclaimer message which auto generates after
the message body. I am still working on proper submission skills.
Regards,
Subhajit Ghosh
--
This email is confidential. If you have received this email in error please
notify us immediately by return email and delete this email and any
attachments. Vix accepts no liability for any damage caused by this email
or any attachments due to viruses, interference, interception, corruption
or unauthorised access.
next prev parent reply other threads:[~2022-11-11 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:12 [PATCH] iio: light: apds9960: Fix iio_event_spec structures Subhajit Ghosh
2022-11-10 13:29 ` Matt Ranostay
2022-11-10 14:45 ` Subhajit Ghosh
2022-11-11 2:50 ` Matt Ranostay
2022-11-11 7:04 ` Subhajit Ghosh [this message]
2022-11-11 11:10 ` Jonathan Cameron
2022-11-11 13:44 ` Subhajit Ghosh
2022-11-12 17:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91e0ffc5-6517-c045-7bac-0b8d904822b9@vixtechnology.com \
--to=subhajit.ghosh@vixtechnology.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox