From: David Lechner <dlechner@baylibre.com>
To: Guillaume Ranquet <granquet@baylibre.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v3 1/2] iio: introduce the FAULT event type
Date: Sat, 18 Jan 2025 11:14:09 -0600 [thread overview]
Message-ID: <938e5570-8e56-4f8d-aff2-3c6354f3330c@baylibre.com> (raw)
In-Reply-To: <20250116-ad4111_openwire-v3-1-ea9ebf29bd1d@baylibre.com>
On 1/16/25 9:01 AM, Guillaume Ranquet wrote:
> Add a new event type to describe an hardware failure.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> ---
...
> enum iio_event_direction {
> @@ -128,6 +129,7 @@ enum iio_event_direction {
> IIO_EV_DIR_NONE,
> IIO_EV_DIR_SINGLETAP,
> IIO_EV_DIR_DOUBLETAP,
> + IIO_EV_DIR_OPENWIRE,
I think it would be a good idea to add additional namespace in the identifier
to make it clear that OPENWIRE only should be used with IIO_EV_TYPE_FAULT.
i.e. IIO_EV_DIR_FAULT_OPENWIRE
> };
>
next prev parent reply other threads:[~2025-01-18 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:01 [PATCH RFC v3 0/2] iio: adc: ad7173: add ad4111 openwire detection support Guillaume Ranquet
2025-01-16 15:01 ` [PATCH RFC v3 1/2] iio: introduce the FAULT event type Guillaume Ranquet
2025-01-18 17:14 ` David Lechner [this message]
2025-01-16 15:01 ` [PATCH RFC v3 2/2] iio: adc: ad7173: add openwire detection support for single conversions Guillaume Ranquet
2025-01-18 17:09 ` Jonathan Cameron
2025-01-18 17:25 ` David Lechner
2025-01-20 14:11 ` Guillaume Ranquet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=938e5570-8e56-4f8d-aff2-3c6354f3330c@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=granquet@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox