From: Jonathan Cameron <jic23@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/13] iio: health/afe440x: Remove unused definitions
Date: Wed, 4 May 2016 11:14:04 +0100 [thread overview]
Message-ID: <98e7d4c8-f88a-4e22-a96d-1406b8de8150@kernel.org> (raw)
In-Reply-To: <1462135023-14445-13-git-send-email-afd@ti.com>
On 01/05/16 21:37, Andrew F. Davis wrote:
> These definitions are not currently used and if the functionality
> they represent is needed the values should be added back to a table
> for easy userspace use.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Applied.
> ---
> drivers/iio/health/afe4403.c | 37 -------------------------------------
> drivers/iio/health/afe4404.c | 20 --------------------
> 2 files changed, 57 deletions(-)
>
> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
> index 059d521..9a08146 100644
> --- a/drivers/iio/health/afe4403.c
> +++ b/drivers/iio/health/afe4403.c
> @@ -39,43 +39,6 @@
> #define AFE4403_TIAGAIN 0x20
> #define AFE4403_TIA_AMB_GAIN 0x21
>
> -/* AFE4403 LEDCNTRL values */
> -#define AFE440X_LEDCNTRL_RANGE_TX_HALF 0x1
> -#define AFE440X_LEDCNTRL_RANGE_TX_FULL 0x2
> -#define AFE440X_LEDCNTRL_RANGE_TX_OFF 0x3
> -
> -/* AFE4403 CONTROL2 values */
> -#define AFE440X_CONTROL2_TX_REF_025 0x0
> -#define AFE440X_CONTROL2_TX_REF_050 0x1
> -#define AFE440X_CONTROL2_TX_REF_100 0x2
> -#define AFE440X_CONTROL2_TX_REF_075 0x3
> -
> -/* AFE4403 CONTROL3 values */
> -#define AFE440X_CONTROL3_CLK_DIV_2 0x0
> -#define AFE440X_CONTROL3_CLK_DIV_4 0x2
> -#define AFE440X_CONTROL3_CLK_DIV_6 0x3
> -#define AFE440X_CONTROL3_CLK_DIV_8 0x4
> -#define AFE440X_CONTROL3_CLK_DIV_12 0x5
> -#define AFE440X_CONTROL3_CLK_DIV_1 0x7
> -
> -/* AFE4403 TIAGAIN_CAP values */
> -#define AFE4403_TIAGAIN_CAP_5_P 0x0
> -#define AFE4403_TIAGAIN_CAP_10_P 0x1
> -#define AFE4403_TIAGAIN_CAP_20_P 0x2
> -#define AFE4403_TIAGAIN_CAP_30_P 0x3
> -#define AFE4403_TIAGAIN_CAP_55_P 0x8
> -#define AFE4403_TIAGAIN_CAP_155_P 0x10
> -
> -/* AFE4403 TIAGAIN_RES values */
> -#define AFE4403_TIAGAIN_RES_500_K 0x0
> -#define AFE4403_TIAGAIN_RES_250_K 0x1
> -#define AFE4403_TIAGAIN_RES_100_K 0x2
> -#define AFE4403_TIAGAIN_RES_50_K 0x3
> -#define AFE4403_TIAGAIN_RES_25_K 0x4
> -#define AFE4403_TIAGAIN_RES_10_K 0x5
> -#define AFE4403_TIAGAIN_RES_1_M 0x6
> -#define AFE4403_TIAGAIN_RES_NONE 0x7
> -
> enum afe4403_fields {
> /* Gains */
> F_RF_LED1, F_CF_LED1,
> diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
> index aa8770b..3a8131d 100644
> --- a/drivers/iio/health/afe4404.c
> +++ b/drivers/iio/health/afe4404.c
> @@ -51,26 +51,6 @@
> /* AFE4404 CONTROL3 register fields */
> #define AFE440X_CONTROL3_OSC_ENABLE BIT(9)
>
> -/* AFE4404 TIA_GAIN_CAP values */
> -#define AFE4404_TIA_GAIN_CAP_5_P 0x0
> -#define AFE4404_TIA_GAIN_CAP_2_5_P 0x1
> -#define AFE4404_TIA_GAIN_CAP_10_P 0x2
> -#define AFE4404_TIA_GAIN_CAP_7_5_P 0x3
> -#define AFE4404_TIA_GAIN_CAP_20_P 0x4
> -#define AFE4404_TIA_GAIN_CAP_17_5_P 0x5
> -#define AFE4404_TIA_GAIN_CAP_25_P 0x6
> -#define AFE4404_TIA_GAIN_CAP_22_5_P 0x7
> -
> -/* AFE4404 TIA_GAIN_RES values */
> -#define AFE4404_TIA_GAIN_RES_500_K 0x0
> -#define AFE4404_TIA_GAIN_RES_250_K 0x1
> -#define AFE4404_TIA_GAIN_RES_100_K 0x2
> -#define AFE4404_TIA_GAIN_RES_50_K 0x3
> -#define AFE4404_TIA_GAIN_RES_25_K 0x4
> -#define AFE4404_TIA_GAIN_RES_10_K 0x5
> -#define AFE4404_TIA_GAIN_RES_1_M 0x6
> -#define AFE4404_TIA_GAIN_RES_2_M 0x7
> -
> enum afe4404_fields {
> /* Gains */
> F_TIA_GAIN_SEP, F_TIA_CF_SEP,
>
next prev parent reply other threads:[~2016-05-04 14:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 20:36 [PATCH 00/13] Rework for AFE440x drivers to prepare for AFE4405 Andrew F. Davis
2016-05-01 20:36 ` [PATCH 01/13] iio: health/afe440x: Fix kernel-doc format Andrew F. Davis
2016-05-04 9:58 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 02/13] iio: health/afe440x: Remove of_match_ptr and ifdefs Andrew F. Davis
2016-05-04 9:59 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 03/13] iio: health/afe440x: Remove unneeded initializers Andrew F. Davis
2016-05-04 9:59 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 04/13] iio: health/afe440x: Always use separate gain values Andrew F. Davis
2016-05-04 10:02 ` Jonathan Cameron
2016-05-04 15:13 ` Andrew F. Davis
2016-05-04 18:33 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 05/13] iio: health/afe440x: Fix scan_index assignment Andrew F. Davis
2016-05-04 10:03 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 06/13] iio: health/afe440x: Remove unneeded offset handling Andrew F. Davis
2016-05-04 10:04 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 07/13] iio: health/afe4404: Remove LED3 input channel Andrew F. Davis
2016-05-04 10:04 ` Jonathan Cameron
2016-05-01 20:36 ` [PATCH 08/13] iio: health/afe440x: Remove channel names Andrew F. Davis
2016-05-04 10:08 ` Jonathan Cameron
2016-05-04 15:28 ` Andrew F. Davis
2016-05-01 20:36 ` [PATCH 09/13] iio: health/afe440x: Use regmap fields Andrew F. Davis
2016-05-04 10:10 ` Jonathan Cameron
2016-05-04 15:30 ` Andrew F. Davis
2016-05-01 20:37 ` [PATCH 10/13] iio: health/afe440x: Make gain settings a modifier for the stages Andrew F. Davis
2016-05-04 10:12 ` Jonathan Cameron
2016-05-01 20:37 ` [PATCH 11/13] iio: health/afe440x: Match LED currents to stages Andrew F. Davis
2016-05-04 10:13 ` Jonathan Cameron
2016-05-01 20:37 ` [PATCH 12/13] iio: health/afe440x: Remove unused definitions Andrew F. Davis
2016-05-04 10:14 ` Jonathan Cameron [this message]
2016-05-01 20:37 ` [PATCH 13/13] iio: health/afe4404: ENSEPGAIN is part of CONTROL2 register Andrew F. Davis
2016-05-04 10:14 ` Jonathan Cameron
2016-05-04 10:25 ` [PATCH 00/13] Rework for AFE440x drivers to prepare for AFE4405 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98e7d4c8-f88a-4e22-a96d-1406b8de8150@kernel.org \
--to=jic23@kernel.org \
--cc=afd@ti.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).