From: Angel Iglesias <ang.iglesiasg@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Paul Cercueil <paul@crapouillou.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: pressure: bmp280: fix datasheet links
Date: Thu, 15 Sep 2022 16:59:54 +0200 [thread overview]
Message-ID: <9b8736f0cc3c68bbec52aab503aeaec74e60ae87.camel@gmail.com> (raw)
In-Reply-To: <20220915143944.79348ecb@jic23-huawei>
On jue, 2022-09-15 at 14:39 +0100, Jonathan Cameron wrote:
> On Tue, 13 Sep 2022 00:26:44 +0200
> Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>
> > Updated links for BMP280 and BME280 datasheets on Bosch website.
> > Datasheet of BMP180 is no longer available on the manufacturer's website,
> > changed the link to a copy hosted by a third party.
> >
> > Changelog in v2:
> > * Added a notice about the situation with bmp180 datasheet and list
> > missing changes from newer versions.
> Change log needs to be below the ---
>
> We don't want that level of detail in the git logs.
>
> I tidied that up whilst applying.
>
> Also, it's not a good idea to have new versions as replies
> to older ones. Leads to very deep nesting in email threads
> and generally makes things less readable. Just post
> a fresh series each time.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for 0-day to see if it can find anything (rather unlikely on this
> patch!)
>
> Jonathan
>
OK, I'll keep it on my mind for future contributions. Thanks for your help and
patience!
Kind regards,
Angel
>
> >
> > Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> > drivers/iio/pressure/bmp280-core.c | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/pressure/bmp280-core.c
> > b/drivers/iio/pressure/bmp280-core.c
> > index fe7aa81e7cc9..01cd32003ca8 100644
> > --- a/drivers/iio/pressure/bmp280-core.c
> > +++ b/drivers/iio/pressure/bmp280-core.c
> > @@ -9,9 +9,15 @@
> > * Driver for Bosch Sensortec BMP180 and BMP280 digital pressure sensor.
> > *
> > * Datasheet:
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > - *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> > + * https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp280-ds001.pdf
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bme280-ds002.pdf
> > + *
> > + * Notice:
> > + * The link to the bmp180 datasheet points to an outdated version missing
> > these changes:
> > + * - Changed document referral from ANP015 to BST-MPS-AN004-00 on page 26
> > + * - Updated equation for B3 param on section 3.5 to ((((long)AC1 * 4 + X3)
> > << oss) + 2) / 4
> > + * - Updated RoHS directive to 2011/65/EU effective 8 June 2011 on page 26
> > */
> >
> > #define pr_fmt(fmt) "bmp280: " fmt
> >
> > base-commit: 2f61ff8272967c9bdcba810aa978170814b08f7c
>
prev parent reply other threads:[~2022-09-15 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:38 [PATCH] iio: pressure: bmp280: fix datasheet links Angel Iglesias
2022-08-19 9:37 ` Andy Shevchenko
2022-08-19 10:31 ` Angel Iglesias
2022-08-19 10:33 ` Andy Shevchenko
2022-08-19 11:09 ` Angel Iglesias
2022-09-12 22:26 ` [PATCH v2] " Angel Iglesias
2022-09-15 13:39 ` Jonathan Cameron
2022-09-15 14:59 ` Angel Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b8736f0cc3c68bbec52aab503aeaec74e60ae87.camel@gmail.com \
--to=ang.iglesiasg@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).