From: "Andrew F. Davis" <afd@ti.com>
To: Alison Schofield <amsfield22@gmail.com>, <jic23@kernel.org>
Cc: <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume
Date: Mon, 16 Jan 2017 10:38:27 -0600 [thread overview]
Message-ID: <9fc37bb7-0a0c-cf68-51e5-c91d096262d7@ti.com> (raw)
In-Reply-To: <20170115035141.GA19547@d830.WORKGROUP>
On 01/14/2017 09:51 PM, Alison Schofield wrote:
> The suspend/resume functions were using dev_to_iio_dev() to get
> the iio_dev. That only works on IIO dev's. Replace it with spi
> functions to get the correct iio_dev.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Was this found with an automated tool? If not, it might be nice to have
a Coccinelle style check for this. Anyway for this and the afe4404
version patch:
Acked-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/iio/health/afe4403.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
> index 9a08146..6bb23a4 100644
> --- a/drivers/iio/health/afe4403.c
> +++ b/drivers/iio/health/afe4403.c
> @@ -422,7 +422,7 @@ MODULE_DEVICE_TABLE(of, afe4403_of_match);
>
> static int __maybe_unused afe4403_suspend(struct device *dev)
> {
> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
> struct afe4403_data *afe = iio_priv(indio_dev);
> int ret;
>
> @@ -443,7 +443,7 @@ static int __maybe_unused afe4403_suspend(struct device *dev)
>
> static int __maybe_unused afe4403_resume(struct device *dev)
> {
> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> + struct iio_dev *indio_dev = spi_get_drvdata(to_spi_device(dev));
> struct afe4403_data *afe = iio_priv(indio_dev);
> int ret;
>
>
next prev parent reply other threads:[~2017-01-16 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 3:51 [PATCH] iio: health: afe4403: retrieve a valid iio_dev in suspend/resume Alison Schofield
2017-01-16 16:38 ` Andrew F. Davis [this message]
2017-01-16 18:10 ` Alison Schofield
2017-01-16 18:22 ` Andrew F. Davis
2017-01-16 18:36 ` Alison Schofield
2017-01-21 13:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc37bb7-0a0c-cf68-51e5-c91d096262d7@ti.com \
--to=afd@ti.com \
--cc=amsfield22@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).