linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: harinath Nampally <harinath922@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	Michael.Hennerich@analog.com, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	jic23@kernel.org
Subject: Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c
Date: Mon, 8 May 2017 01:35:33 -0400	[thread overview]
Message-ID: <CAAGUq_rn1SA2wAH8vs_bHWFsKMi-0tYaJAV7rETM7TzcEb97nw@mail.gmail.com> (raw)
In-Reply-To: <20170508043228.GA1553@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hi Greg,

Thank you so much for your time to review.
Sure I will break up into multiple patches and create patch series.
But I wonder 'one thing' per patch means one kind of warnings per patch?
For example if I have multiple fixes for similar warnings like 'Symbolic
permissions'. Can they all go in a single patch.
 So patch 0/10 for all 'Symbolic permissions' and path 1/10 for all
'alignment warnings' and so on and so forth.

Please let me know.

Thanks,
Harinath


On May 8, 2017 12:32 AM, "Greg KH" <gregkh@linuxfoundation.org> wrote:

On Mon, May 08, 2017 at 12:16:17AM -0400, Harinath Nampally wrote:
> All below warnings are found and fixed by checkpatch.pl:
> CHECK: struct mutex definition without comment
> CHECK: Alignment should match open parenthesis
> WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred.

You should only don "one thing" per patch, and no, "fix coding style
issues" is not "one thing" :)

Please break this up into multiple patches and send it as a patch
series.

thanks,

greg k-h

[-- Attachment #2: Type: text/html, Size: 2437 bytes --]

  reply	other threads:[~2017-05-08  5:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08  4:16 [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c Harinath Nampally
2017-05-08  4:32 ` Greg KH
2017-05-08  5:35   ` harinath Nampally [this message]
2017-05-08  5:38   ` harinath Nampally
2017-05-08  5:42     ` Greg KH
2017-05-09  2:00 ` [PATCH 0/3] coding style warnings fixes Harinath Nampally
2017-05-09  2:00   ` [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-09  7:46     ` Dan Carpenter
2017-05-09 23:41       ` [PATCH v2 0/3] coding style warnings fixes Harinath Nampally
2017-05-09 23:41         ` [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally
2017-05-14 15:24           ` Jonathan Cameron
2017-05-09 23:41         ` [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-14 15:26           ` Jonathan Cameron
2017-05-09 23:41         ` [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally
2017-05-14 15:29           ` Jonathan Cameron
2017-05-15  3:10             ` harinath Nampally
2017-05-14 15:23         ` [PATCH v2 0/3] coding style warnings fixes Jonathan Cameron
2017-05-09  2:00   ` [PATCH 2/3] staging: iio: meter: Fix the identations for proper alignments Harinath Nampally
2017-05-09  2:00   ` [PATCH 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions Harinath Nampally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAGUq_rn1SA2wAH8vs_bHWFsKMi-0tYaJAV7rETM7TzcEb97nw@mail.gmail.com \
    --to=harinath922@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).