From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Jonathan Cameron <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Giuseppe Barba <giuseppe.barba@st.com>,
Denis Ciocca <denis.ciocca@st.com>,
Crestez Dan Leonard <cdleonard@gmail.com>
Subject: Re: [PATCH 2/2 v4] iio: st_sensors: read surplus samples in trigger
Date: Mon, 9 May 2016 16:47:28 +0200 [thread overview]
Message-ID: <CACRpkdZ0HM3C+6uAKVTLg7SphV7yHsPH19cjy5To+1-6OF4mCg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbEnTYFe=xd-u0JcyOGRrHydRSVBvYHsWvc1T8CsmJSQA@mail.gmail.com>
On Sun, May 8, 2016 at 10:55 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> I thought about it tonight, and I need to add one more thing
> to make the solution perfect: avoid registering the interrupt
> with IRQF_ONESHOT.
After a bunch of tests it appears that this is actually all
that is needed.
The interrupt core will re-wake the thread if a second
IRQ came in to the hardirq (top half) during the processing
of the thread.
As we're checking status and dealing with shared
interrupts this makes sure we never miss events.
> Then we need the top half to tell the bottom half that a new
> IRQ has arrived.
So this is not needed.
Sending a v5.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-05-09 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 10:25 [PATCH 1/2 v4] iio: st_sensors: switch to a threaded interrupt Linus Walleij
2016-05-07 10:25 ` [PATCH 2/2 v4] iio: st_sensors: read surplus samples in trigger Linus Walleij
2016-05-07 11:15 ` Jonathan Cameron
2016-05-08 8:55 ` Linus Walleij
2016-05-09 14:47 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ0HM3C+6uAKVTLg7SphV7yHsPH19cjy5To+1-6OF4mCg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=cdleonard@gmail.com \
--cc=denis.ciocca@st.com \
--cc=giuseppe.barba@st.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).