From: Linus Walleij <linus.walleij@linaro.org>
To: Jakob Hauser <jahau@rocketmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 4/7] iio: magnetometer: yas530: Change data type of hard_offsets to signed
Date: Thu, 9 Jun 2022 10:54:04 +0200 [thread overview]
Message-ID: <CACRpkdZJkG98feCSB2EUELRSNBocEV+x_1q3MtkZufJbPMfiqQ@mail.gmail.com> (raw)
In-Reply-To: <1b6e152e1dda138c68ea8c207e46f91337989d35.1654727058.git.jahau@rocketmail.com>
On Thu, Jun 9, 2022 at 1:38 AM Jakob Hauser <jahau@rocketmail.com> wrote:
> The "hard_offsets" are currently unsigned u8 but they should be signed as they
> can get negative. They are signed in function yas5xx_meaure_offsets() and in the
> Yamaha drivers [1][2].
>
> [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156
> [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91
>
> Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-06-09 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1654727058.git.jahau.ref@rocketmail.com>
2022-06-08 23:36 ` [PATCH 0/7] Add support for magnetometer Yamaha YAS537 Jakob Hauser
2022-06-08 23:38 ` [PATCH 1/7] iio: magnetometer: yas530: Change range of data in volatile register Jakob Hauser
2022-06-09 8:50 ` Linus Walleij
2022-06-08 23:38 ` [PATCH 2/7] iio: magnetometer: yas530: Correct scaling of magnetic axes Jakob Hauser
2022-06-09 8:52 ` Linus Walleij
2022-06-08 23:38 ` [PATCH 3/7] iio: magnetometer: yas530: Correct temperature handling Jakob Hauser
2022-06-09 8:53 ` Linus Walleij
2022-06-08 23:38 ` [PATCH 4/7] iio: magnetometer: yas530: Change data type of hard_offsets to signed Jakob Hauser
2022-06-09 8:54 ` Linus Walleij [this message]
2022-06-10 14:22 ` Andy Shevchenko
2022-06-08 23:38 ` [PATCH 5/7] iio: magnetometer: yas530: Change data type of calibration coefficients Jakob Hauser
2022-06-09 8:55 ` Linus Walleij
2022-06-08 23:38 ` [PATCH 6/7] iio: magnetometer: yas530: Remove redundant defaults on switch devid Jakob Hauser
2022-06-09 8:55 ` Linus Walleij
2022-06-10 14:24 ` Andy Shevchenko
2022-06-08 23:38 ` [PATCH 7/7] iio: magnetometer: yas530: Add YAS537 variant Jakob Hauser
2022-06-09 8:56 ` Linus Walleij
2022-06-10 14:31 ` Andy Shevchenko
2022-06-10 23:57 ` Jakob Hauser
2022-06-11 10:56 ` Andy Shevchenko
2022-06-11 14:00 ` Jakob Hauser
2022-06-11 20:22 ` Andy Shevchenko
2022-06-11 21:19 ` Jakob Hauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZJkG98feCSB2EUELRSNBocEV+x_1q3MtkZufJbPMfiqQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=jahau@rocketmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).