From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Jonathan Cameron <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Denis CIOCCA <denis.ciocca@st.com>,
Crestez Dan Leonard <leonard.crestez@intel.com>,
linux-iio-owner@vger.kernel.org
Subject: Re: [RFC] iio: accel: st_accel: Add lis3l02dq support
Date: Tue, 24 May 2016 10:45:47 +0200 [thread overview]
Message-ID: <CACRpkdZsqKcrQKUhY7U-VkZodUbNo8BoaesFMHvLcYTAGGDLcw@mail.gmail.com> (raw)
In-Reply-To: <71875CD9-27C6-4DC5-9F78-F9486DF12612@jic23.retrosnub.co.uk>
On Mon, May 23, 2016 at 6:29 PM, Jonathan Cameron
<jic23@jic23.retrosnub.co.uk> wrote:
> I forgot this part also has gain and offset trim registers. Will add them before
> applying as that is easy enough and reduces the differences further.
>
> These exist on some other parts but we can add them any time.
LIS3LV02DL also has x,y,z offset and gain trim registers, but when
I read up on it, I understood that these are just factory-programmed
registers. I.e. they are undocumented in the register list, but a table
states them as "calibration" and "loaded at boot".
So I always understood them as something the sensor loads at
boot to calibrate itself, so you can ignore the contents, and they
probably exist on the other sensors too, albeit undocumented as
they have no use.
I toyed with the idea of reading them and pusing the values to the
entropy pool with add_device_randomness() as they are device-unique
data.
But if you have proper docs on them I guess maybe they are used
differently on your sensor...
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-05-24 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 19:39 [RFC] iio: accel: st_accel: Add lis3l02dq support Jonathan Cameron
2016-05-22 20:04 ` Jonathan Cameron
2016-05-23 7:43 ` Linus Walleij
2016-05-23 14:13 ` jic23
2016-05-23 16:29 ` Jonathan Cameron
2016-05-24 8:45 ` Linus Walleij [this message]
2016-05-24 8:57 ` jic23
2016-05-29 19:08 ` Jonathan Cameron
2016-07-03 14:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZsqKcrQKUhY7U-VkZodUbNo8BoaesFMHvLcYTAGGDLcw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=denis.ciocca@st.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=jic23@kernel.org \
--cc=leonard.crestez@intel.com \
--cc=linux-iio-owner@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).