From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Stephan Gerhold" <stephan@gerhold.net>,
linux-iio@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] iio: accel: bmc150: Fix irq assumption regression
Date: Mon, 27 Oct 2025 18:24:25 +0100 [thread overview]
Message-ID: <CACRpkdb9GYL3dQzn28Q5E_-keJdLLA+TiXxTuNf1aaevKqHJYA@mail.gmail.com> (raw)
In-Reply-To: <aP9dqnGb_tdWdr7y@smile.fi.intel.com>
On Mon, Oct 27, 2025 at 12:55 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
> On Mon, Oct 27, 2025 at 11:18:17AM +0100, Linus Walleij wrote:
> Hmm... Isn't this already being discussed somewhere? I have some déjà-vu.
I brought it up on the PostmarkeOS IRC, otherwise I don't
know.
> > + /* We do not always have an IRQ */
> > + if (!data->has_irq)
>
> Wouldn't check for 0 be enough?
>
> if (!data->irq)
But this driver does not store the IRQ number in the
instance struct because it isn't used outside of the probe()
function.
The information that needs to be stored is bool so that's
why I stored a bool.
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-10-27 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 10:18 [PATCH] iio: accel: bmc150: Fix irq assumption regression Linus Walleij
2025-10-27 11:55 ` Andy Shevchenko
2025-10-27 17:24 ` Linus Walleij [this message]
2025-10-28 11:34 ` Andy Shevchenko
2025-10-28 14:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb9GYL3dQzn28Q5E_-keJdLLA+TiXxTuNf1aaevKqHJYA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).