From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve0-f171.google.com ([209.85.128.171]:45727 "EHLO mail-ve0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751715Ab3JYPmH (ORCPT ); Fri, 25 Oct 2013 11:42:07 -0400 Received: by mail-ve0-f171.google.com with SMTP id pa12so2409657veb.30 for ; Fri, 25 Oct 2013 08:42:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1381814135-16252-1-git-send-email-ch.naveen@samsung.com> References: <1381479821-17276-1-git-send-email-ch.naveen@samsung.com> <1381814135-16252-1-git-send-email-ch.naveen@samsung.com> Date: Fri, 25 Oct 2013 08:42:05 -0700 Message-ID: Subject: Re: [PATCH v4] iio: exynos_adc: use wait_for_completion_timeout instead of interruptible From: Doug Anderson To: Naveen Krishna Chatradhi , Grant Grundler Cc: linux-iio , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Greg Kroah-Hartman , Naveen Krishna , Lars-Peter Clausen , "cpgs ." Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Naveen, On Mon, Oct 14, 2013 at 10:15 PM, Naveen Krishna Chatradhi wrote: > This patch does the following > 1. The irq routine is so simple (just one register read) shouldn't be long > Hence, reduce the timeout to 100milli secs, > 2. With 100ms of wait time, interruptible is very much unnecessary. > Hence, use wait_for_completion_timeout instead of > wait_for_completion_interruptible_timeout > 3. Reset software if a timeout happens. > 4. Add INIT_COMPLETION before the wait_for_completion_timeout in raw_read() > > Note: submitted for review at https://patchwork.kernel.org/patch/2279591/ > > Signed-off-by: Naveen Krishna Chatradhi > Cc: Doug Anderson > Cc: Lars-Peter Clausen > --- > Changes since v1: > As per discussion at > http://marc.info/?l=linux-kernel&m=136517637228869&w=3 > > Changes since v2: > None. > Rebased and reposting. > > Changes since v3: > 1. commit message change and > 2. removed an unncessary assignment > > drivers/iio/adc/exynos_adc.c | 69 +++++++++++++++++++++++------------------- > 1 file changed, 38 insertions(+), 31 deletions(-) Please spin to match the changes that Grant requested on our gerrit at . Thanks! :) -Doug