Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

[Steve Presser <steve@pressers.name>]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

Andy,

Where did the assertion the second device is a magnetometer come from? Just
the data sheet?

Steve

On Tue, Jan 30, 2018, 12:05 PM Andy Shevchenko <andy.shevchenko@gmail.com>
wrote:

> On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron
> > <Jonathan.Cameron@huawei.com> wrote:
> >> On Mon, 29 Jan 2018 16:07:02 +0200
> >> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >
> >>> > But that would take much longer.  Feel free to propose it and a patch
> >>> > removing the ifdef fun if you like!
> >
> >>> Where can I see the patch?
> >
> >> Doh. I clearly forgot to push out.  Should be able to push to
> >> iio.git on kernel.org later.
> >
> > Thanks, I can see it now.
> >
> > This patch almost wrong. Not by functionality it brings, but by style.
>
> Oy vey, the second device is *not* accelerometer, it is a magnetometer [1].
>
> [1]: https://www.mouser.com/ds/2/783/BST-BMC150-DS000-04-786477.pdf
>
> > I'll send soon a series of fixes to the driver (compile tested only)
> > to provide my view on the matters.
> >
> > P.S. In the future (I have some kind of deja vu I have told this
> > already to someone), please, Cc one or more of Rafael, Mika and/or me
> > for ACPI matters.
>
> --
> With Best Regards,
> Andy Shevchenko
>

[-- Attachment #2: Type: text/html, Size: 2264 bytes --]