From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <010001602cf53153-39ad69f1-1b39-4e6d-a748-9455a16c2fbd-000000@email.amazonses.com> <20171210182152.70ad8fbf@archlinux> <01000160dccefcb4-25edfd89-56f3-486f-88a4-cb8c07253974-000000@email.amazonses.com> <20180114104330.2aa7c1fd@archlinux> <20180128094021.572ab366@archlinux> <20180130160107.000006df@huawei.com> In-Reply-To: From: Steve Presser Date: Tue, 30 Jan 2018 17:25:32 +0000 Message-ID: Subject: Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200 To: Andy Shevchenko Cc: Hans de Goede , Hartmut Knaack , Jeremy Cline , Jonathan Cameron , Jonathan Cameron , Lars Kellogg-Stedman , Lars-Peter Clausen , Linux Kernel Mailing List , Mika Westerberg , Peter Meerwald-Stadler , Wolfram Sang , linux-iio@vger.kernel.org Content-Type: multipart/alternative; boundary="089e082409a8038682056401a711" List-ID: --089e082409a8038682056401a711 Content-Type: text/plain; charset="UTF-8" Andy, Where did the assertion the second device is a magnetometer come from? Just the data sheet? Steve On Tue, Jan 30, 2018, 12:05 PM Andy Shevchenko wrote: > On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko > wrote: > > On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron > > wrote: > >> On Mon, 29 Jan 2018 16:07:02 +0200 > >> Andy Shevchenko wrote: > > > >>> > But that would take much longer. Feel free to propose it and a patch > >>> > removing the ifdef fun if you like! > > > >>> Where can I see the patch? > > > >> Doh. I clearly forgot to push out. Should be able to push to > >> iio.git on kernel.org later. > > > > Thanks, I can see it now. > > > > This patch almost wrong. Not by functionality it brings, but by style. > > Oy vey, the second device is *not* accelerometer, it is a magnetometer [1]. > > [1]: https://www.mouser.com/ds/2/783/BST-BMC150-DS000-04-786477.pdf > > > I'll send soon a series of fixes to the driver (compile tested only) > > to provide my view on the matters. > > > > P.S. In the future (I have some kind of deja vu I have told this > > already to someone), please, Cc one or more of Rafael, Mika and/or me > > for ACPI matters. > > -- > With Best Regards, > Andy Shevchenko > --089e082409a8038682056401a711 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Andy,

Where did the assertion the second device is a magnet= ometer come from? Just the data sheet?

Steve


On Tue, Jan 30, 2018= , 12:05 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko <andy.she= vchenko@gmail.com> wrote:
> On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron
> <J= onathan.Cameron@huawei.com> wrote:
>> On Mon, 29 Jan 2018 16:07:02 +0200
>> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
>>> > But that would take much longer.=C2=A0 Feel free to propo= se it and a patch
>>> > removing the ifdef fun if you like!
>
>>> Where can I see the patch?
>
>> Doh. I clearly forgot to push out.=C2=A0 Should be able to push to=
>> iio.git on kernel.org later.
>
> Thanks, I can see it now.
>
> This patch almost wrong. Not by functionality it brings, but by style.=

Oy vey, the second device is *not* accelerometer, it is a magnetometer [1].=

[1]: https://www.mouser.com/ds/2/783/B= ST-BMC150-DS000-04-786477.pdf

> I'll send soon a series of fixes to the driver (compile tested onl= y)
> to provide my view on the matters.
>
> P.S. In the future (I have some kind of deja vu I have told this
> already to someone), please, Cc one or more of Rafael, Mika and/or me<= br> > for ACPI matters.

--
With Best Regards,
Andy Shevchenko
--089e082409a8038682056401a711--