From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: daniel.baluta@gmail.com In-Reply-To: <551C2E23.2080400@linux.intel.com> References: <551C2E23.2080400@linux.intel.com> Date: Wed, 1 Apr 2015 20:54:07 +0300 Message-ID: Subject: Re: [PATCH v1 1/1] iio: ltr301: Add support for ltr301 From: Daniel Baluta To: Kuppuswamy Sathyanarayanan Cc: Daniel Baluta , Jonathan Cameron , Peter Meerwald , "linux-iio@vger.kernel.org" , Srinivas Pandruvada Content-Type: text/plain; charset=UTF-8 List-ID: On Wed, Apr 1, 2015 at 8:42 PM, sathyanarayanan kuppuswamy wrote: > Hi Daniel, > > On 04/01/2015 08:34 AM, Daniel Baluta wrote: >> >> On Wed, Apr 1, 2015 at 7:06 AM, Kuppuswamy Sathyanarayanan >> wrote: >>> >>> Added support for Liteon 301 Ambient light sensor. Since >>> LTR301 and LTR501 are register compatible(and even have same >>> part id), LTR501 driver has been extended to support both >>> devices. LTR501 is similar to LTR301 in ALS sensing, But the >>> only difference is, LTR501 also supports proximity sensing. >>> >>> LTR501 - ALS + Proximity combo >>> LTR301 - ALS sensor. >>> >>> Following are the data sheets for both devices: >>> >>> >>> http://optoelectronics.liteon.com/upload/download/DS86-2013-0004/S_110_LTR-303ALS-01_DS_V1.pdf >>> >>> >>> http://optoelectronics.liteon.com/upload/download/DS86-2012-0006/S_110_LTR-501ALS-01_PrelimDS_ver1[1].pdf >> >> One more thing. The datasheet you posted is for LTR303 not LTR301. >> Which chip are you adding support for? > > No. I posted link for the wrong data sheet. I will fix it once I find a > proper link. Oh, then it's all right. Here is the link for my patchset: https://lkml.org/lkml/2015/3/31/197 I guess you can take my first patch: * iio: light: ltr501: Fix alignment to match open parenthesis add to your patchset and rebase your changes on it. Then when I'll receive the LTR501 device I will rebase my other patch on your changes. thanks, Daniel.