From: Daniel Baluta <daniel.baluta@gmail.com>
To: rishabh hardas <rishabheudyptula@gmail.com>
Cc: Peter Meerwald <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] Fixed a coding style issue as a part of Eudyptula Challenge
Date: Sat, 7 Jan 2017 11:23:08 +0200 [thread overview]
Message-ID: <CAEnQRZCgiUXEZX8iwJV3MU00KoywaPsNFy32QkuEGRui_itgJw@mail.gmail.com> (raw)
In-Reply-To: <1483695570-13082-1-git-send-email-rishabheudyptula@gmail.com>
Hi rishabh,
Congrats on reaching that far on Eudyptula challenge.
Anyhow, you should write a proper commit message to this patch.
The subject should briefly describe why the patch is needed.
E.g: iio:trigger: Fix coding style
What actually has been fixed and how did you find it. (I assume you
used checkpatch.pl)
Daniel.
On Fri, Jan 6, 2017 at 11:39 AM, rishabh hardas
<rishabheudyptula@gmail.com> wrote:
> Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com>
> ---
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index 38dca69..9658f20 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> @@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
> return sprintf(buf, "%lu\n", val);
> }
>
> -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
> +static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
> iio_bfin_tmr_frequency_store);
>
> static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-07 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 9:39 [PATCH] Fixed a coding style issue as a part of Eudyptula Challenge rishabh hardas
2017-01-07 9:23 ` Daniel Baluta [this message]
2017-01-07 16:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZCgiUXEZX8iwJV3MU00KoywaPsNFy32QkuEGRui_itgJw@mail.gmail.com \
--to=daniel.baluta@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rishabheudyptula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).